feat(get-medias/sort): add option to customize sort on getMedias

[matheusdavidson]

This PR will add the ability to sort getMedias using custom keys and ascending.
#36

[nkalupahana]

Thank you so much for your contribution! Two quick things before I review:

• Could you make the two options in MediaSort optional? Users may want to specify one but not the other.
• Can you have multiple sort descriptors at a time? If so, it would be great if you could add that functionality; I don't think it would be too hard to add.

Again, thank you for contributing! We really appreciate it.

[stewones]

Thank you so much for your contribution! Two quick things before I review:

• Could you make the two options in MediaSort optional? Users may want to specify one but not the other.
• Can you have multiple sort descriptors at a time? If so, it would be great if you could add that functionality; I don't think it would be too hard to add.

Again, thank you for contributing! We really appreciate it.

agree. and would make it clear through the doc block what the default value is for both options.

for point 2 I think it could potentially hold off merging this PR. maybe just define a broader type definition that can support multiple sort descriptors in the future without breaking the proposed feature.

[stewones]

looking better at it, I think what @nkalupahana is proposing is to pass an array of keys instead of a string. So I tend to agree and we stay consistent with iOS API.

[matheusdavidson]

Hi @nkalupahana and @stewones, thanks for reviewing.

I agree with both points but on point 1 the key can't be optional after implementing point 2, because being an array to enable multiple sort options, the key is the only important part inside the array, for example, an array of [{ ascending: false }, { ascending: true }] wouldn't make sense, but [{ key: creationDate }, { key: isFavorite }] makes sense.

So here what I did:

• make sort accept: string | MediaSort[]
• when sort is a string, it will be used as a key and default ascending to false.
• when sort is an array, it will loop and append to sortDescriptors, here the key is required and ascending optional, if one is not provided true is used by default.

[stewones]

good job, LGTM.

[matheusdavidson]

Sorry @nkalupahana, didn't meant to remove you from review, github only gave me an option to ask @stewones, please review it as well

[nkalupahana]

Looks good! Could you remove the debug prints? Other than that, I think we're good to get this merged :) thanks for your contribution!

[matheusdavidson]

@nkalupahana, @stewones, removed debug print. Should be good to go now.