Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating pyyaml to fix #25 #27

Merged
merged 1 commit into from
Jan 7, 2019
Merged

updating pyyaml to fix #25 #27

merged 1 commit into from
Jan 7, 2019

Conversation

fdosani
Copy link
Member

@fdosani fdosani commented Jan 4, 2019

@theianrobertson do you mind reviewing this?

  • Essentially there is a venerability with pyyaml. See: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-18342
  • going from 3.12 to 4.2b4 provides a fix.
  • we are only using pyyaml for reading in configs so there shouldn't be any particular regressions
    • unit and integration tests are working good
  • will pin to a more stable version down the road once 4.2 is officially released.

@theianrobertson
Copy link
Contributor

:shipit:

@fdosani fdosani merged commit 4572b9d into master Jan 7, 2019
@fdosani fdosani deleted the pyyaml-fix branch January 8, 2019 03:46
dasjyao pushed a commit to dasjyao/Data-Load-and-Copy-using-Python that referenced this pull request Oct 29, 2019
@fdosani
updating pyyaml to fix capitalone#25 (capitalone#27)
bd49e74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theianrobertson theianrobertson Awaiting requested review from theianrobertson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fdosani @theianrobertson