Skip to content

Commit

Permalink
fix(icons): update xlink:href to use carbon-icons (#2451)
Browse files Browse the repository at this point in the history
* fix(icons): update xlink:href to use carbon-icons

* test(copy-button): update xlink:href to use carbon-icons
  • Loading branch information
BRIAN T. HAN authored and GitHub Enterprise committed Mar 24, 2017
1 parent f276311 commit 85cabc4
Show file tree
Hide file tree
Showing 32 changed files with 128 additions and 128 deletions.
8 changes: 4 additions & 4 deletions src/components/accordion/accordion.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<li tabindex="0" data-accordion-item class="bx--accordion__item">
<div class="bx--accordion__heading">
<svg class="bx--accordion__arrow">
<use xlink:href="/@console/bluemix-icons/bluemix-icons.svg#icon--chevron--right"></use>
<use xlink:href="/carbon-icons/bluemix-icons.svg#icon--chevron--right"></use>
</svg>
<p class="bx--accordion__title">Label</p>
</div>
Expand All @@ -13,7 +13,7 @@
<li tabindex="0" data-accordion-item class="bx--accordion__item">
<div class="bx--accordion__heading">
<svg class="bx--accordion__arrow">
<use xlink:href="/@console/bluemix-icons/bluemix-icons.svg#icon--chevron--right"></use>
<use xlink:href="/carbon-icons/bluemix-icons.svg#icon--chevron--right"></use>
</svg>
<p class="bx--accordion__title">Label with multiple words</p>
</div>
Expand All @@ -24,7 +24,7 @@
<li tabindex="0" data-accordion-item class="bx--accordion__item">
<div class="bx--accordion__heading">
<svg class="bx--accordion__arrow">
<use xlink:href="/@console/bluemix-icons/bluemix-icons.svg#icon--chevron--right"></use>
<use xlink:href="/carbon-icons/bluemix-icons.svg#icon--chevron--right"></use>
</svg>
<p class="bx--accordion__title">Label</p>
</div>
Expand All @@ -35,7 +35,7 @@
<li tabindex="0" data-accordion-item class="bx--accordion__item">
<div class="bx--accordion__heading">
<svg class="bx--accordion__arrow">
<use xlink:href="/@console/bluemix-icons/bluemix-icons.svg#icon--chevron--right"></use>
<use xlink:href="/carbon-icons/bluemix-icons.svg#icon--chevron--right"></use>
</svg>
<p class="bx--accordion__title">Label</p>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/components/accordion/migrate-to-7.x.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Update `<use xlink:href>` to a local path of bluemix-icons.svg, which should loo

```html
<svg class="bx--accordion__arrow">
<use xlink:href="/@console/bluemix-icons/bluemix-icons.svg#chevron--right"></use>
<use xlink:href="/carbon-icons/bluemix-icons.svg#chevron--right"></use>
</svg>
```

Expand Down
2 changes: 1 addition & 1 deletion src/components/button/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ Be aware that only `--glyph` icons should be used with buttons.
<button class="bx--btn bx--btn--secondary" type="button">
Secondary
<svg class="bx--btn__icon">
<use xlink:href="/@console/bluemix-icons/bluemix-icons.svg#add--glyph"></use>
<use xlink:href="/carbon-icons/bluemix-icons.svg#add--glyph"></use>
</svg>
</button>
```
4 changes: 2 additions & 2 deletions src/components/button/danger-button.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
<button class="bx--btn bx--btn--danger" type="button">
Danger
<svg class="bx--btn__icon">
<use xlink:href="/@console/bluemix-icons/bluemix-icons.svg#icon--add--glyph"></use>
<use xlink:href="/carbon-icons/bluemix-icons.svg#icon--add--glyph"></use>
</svg>
</button>
<button class="bx--btn bx--btn--danger bx--btn--sm" type="button">Danger button</button>
<button class="bx--btn bx--btn--danger bx--btn--sm" type="button">
Danger button
<svg class="bx--btn__icon">
<use xlink:href="/@console/bluemix-icons/bluemix-icons.svg#icon--add--glyph"></use>
<use xlink:href="/carbon-icons/bluemix-icons.svg#icon--add--glyph"></use>
</svg>
</button>
4 changes: 2 additions & 2 deletions src/components/button/primary-button.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
<button class="bx--btn bx--btn--primary" type="button">
Primary
<svg class="bx--btn__icon">
<use xlink:href="/@console/bluemix-icons/bluemix-icons.svg#icon--add--glyph"></use>
<use xlink:href="/carbon-icons/bluemix-icons.svg#icon--add--glyph"></use>
</svg>
</button>
<button class="bx--btn bx--btn--primary bx--btn--sm" type="button">Primary button</button>
<button class="bx--btn bx--btn--primary bx--btn--sm" type="button">
Primary button
<svg class="bx--btn__icon">
<use xlink:href="/@console/bluemix-icons/bluemix-icons.svg#icon--add--glyph"></use>
<use xlink:href="/carbon-icons/bluemix-icons.svg#icon--add--glyph"></use>
</svg>
</button>
4 changes: 2 additions & 2 deletions src/components/button/secondary-button.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
<button class="bx--btn bx--btn--secondary" type="button">
Secondary
<svg class="bx--btn__icon">
<use xlink:href="/@console/bluemix-icons/bluemix-icons.svg#icon--add--glyph"></use>
<use xlink:href="/carbon-icons/bluemix-icons.svg#icon--add--glyph"></use>
</svg>
</button>
<button class="bx--btn bx--btn--secondary bx--btn--sm" type="button">Secondary button</button>
<button class="bx--btn bx--btn--secondary bx--btn--sm" type="button">
Secondary button
<svg class="bx--btn__icon">
<use xlink:href="/@console/bluemix-icons/bluemix-icons.svg#icon--add--glyph"></use>
<use xlink:href="/carbon-icons/bluemix-icons.svg#icon--add--glyph"></use>
</svg>
</button>
6 changes: 3 additions & 3 deletions src/components/card/card--with-status.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<!-- OverflowMenu -->
<div data-overflow-menu class="bx--overflow-menu" tabindex="0" aria-label="List of options">
<svg class="bx--overflow-menu__icon">
<use xlink:href="/@console/bluemix-icons/bluemix-icons.svg#icon--overflow-menu"></use>
<use xlink:href="/carbon-icons/bluemix-icons.svg#icon--overflow-menu"></use>
</svg>
<ul class="bx--overflow-menu-options">
<li class="bx--overflow-menu-options__option">
Expand Down Expand Up @@ -48,12 +48,12 @@ <h3 id="card-title" class="bx--about__title--name">Card Name</h3>
<div class="bx--card-footer__app-actions">
<button class="bx--app-actions__button" id="restart-app" aria-label="restart-app">
<svg class="bx--app-actions__button--icon">
<use xlink:href="/@console/bluemix-icons/bluemix-icons.svg#icon--restart--glyph"></use>
<use xlink:href="/carbon-icons/bluemix-icons.svg#icon--restart--glyph"></use>
</svg>
</button>
<button class="bx--app-actions__button" id="load-app" aria-label="load-app">
<svg class="bx--app-actions__button--icon">
<use xlink:href="/@console/bluemix-icons/bluemix-icons.svg#icon--launch--glyph"></use>
<use xlink:href="/carbon-icons/bluemix-icons.svg#icon--launch--glyph"></use>
</svg>
</button>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/components/card/card.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<!-- OverflowMenu -->
<div data-overflow-menu class="bx--overflow-menu" tabindex="0" aria-label="List of options">
<svg class="bx--overflow-menu__icon">
<use xlink:href="/@console/bluemix-icons/bluemix-icons.svg#icon--overflow-menu"></use>
<use xlink:href="/carbon-icons/bluemix-icons.svg#icon--overflow-menu"></use>
</svg>
<ul class="bx--overflow-menu-options">
<li class="bx--overflow-menu-options__option">
Expand Down
4 changes: 2 additions & 2 deletions src/components/checkbox/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ With `input` and `label` as siblings
<label for="bx--checkbox" class="bx--checkbox-label">
<span class="bx--checkbox-appearance">
<svg class="bx--checkbox-checkmark">
<use xlink:href="/@console/bluemix-icons/bluemix-icons.svg#checkmark"></use>
<use xlink:href="/carbon-icons/bluemix-icons.svg#checkmark"></use>
</svg>
</span>
Checkbox (input + label)
Expand All @@ -38,7 +38,7 @@ With `label` wrapping `input`
<input class="bx--checkbox" type="checkbox" value="yellow" name="checkbox">
<span class="bx--checkbox-appearance">
<svg class="bx--checkbox-checkmark">
<use xlink:href="/@console/bluemix-icons/bluemix-icons.svg#checkmark"></use>
<use xlink:href="/carbon-icons/bluemix-icons.svg#checkmark"></use>
</svg>
</span>
<span class="bx--checkbox-label-text">Checkbox (label > input)</span>
Expand Down
4 changes: 2 additions & 2 deletions src/components/checkbox/checkbox.html
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<label for="bx--checkbox-red" class="bx--checkbox-label">
<span class="bx--checkbox-appearance">
<svg class="bx--checkbox-checkmark">
<use xlink:href="/@console/bluemix-icons/bluemix-icons.svg#icon--checkmark"></use>
<use xlink:href="/carbon-icons/bluemix-icons.svg#icon--checkmark"></use>
</svg>
</span>
Red
Expand All @@ -18,7 +18,7 @@
<input id="bx--checkbox-blue" class="bx--checkbox" type="checkbox" value="yellow" name="checkbox">
<span class="bx--checkbox-appearance">
<svg class="bx--checkbox-checkmark">
<use xlink:href="/@console/bluemix-icons/bluemix-icons.svg#icon--checkmark"></use>
<use xlink:href="/carbon-icons/bluemix-icons.svg#icon--checkmark"></use>
</svg>
</span>
<span class="bx--checkbox-label-text">Blue</span>
Expand Down
2 changes: 1 addition & 1 deletion src/components/code-snippet/code-snippet--code.html
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
</div>
<button data-copy-btn class="bx--snippet-button">
<svg class="bx--snippet__icon">
<use xlink:href="/@console/bluemix-icons/bluemix-icons.svg#icon--copy"></use>
<use xlink:href="/carbon-icons/bluemix-icons.svg#icon--copy"></use>
</svg>
<div class="bx--btn--copy__feedback" data-feedback="Copied!"></div>
</button>
Expand Down
2 changes: 1 addition & 1 deletion src/components/code-snippet/code-snippet--terminal.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
</div>
<button data-copy-btn class="bx--snippet-button">
<svg class="bx--snippet__icon">
<use xlink:href="/@console/bluemix-icons/bluemix-icons.svg#icon--copy"></use>
<use xlink:href="/carbon-icons/bluemix-icons.svg#icon--copy"></use>
</svg>
<div class="bx--btn--copy__feedback" data-feedback="Copied!"></div>
</button>
Expand Down
2 changes: 1 addition & 1 deletion src/components/copy-button/copy-button.html
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<button data-copy-btn class="bx--btn bx--btn--primary bx--btn--copy bx--btn--sm">
Copy button
<svg class="bx--btn__icon">
<use xlink:href="/@console/bluemix-icons/bluemix-icons.svg#icon--add--glyph"></use>
<use xlink:href="/carbon-icons/bluemix-icons.svg#icon--add--glyph"></use>
</svg>
<div class="bx--btn--copy__feedback" data-feedback="Copied!"></div>
</button>
6 changes: 3 additions & 3 deletions src/components/data-table/data-table--simple.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,19 @@
<th class="bx--table-header bx--table-sort" data-event="sort">
<span>First Name</span>
<svg class="bx--table-sort__svg">
<use xlink:href="/@console/bluemix-icons/bluemix-icons.svg#icon--caret--down"></use>
<use xlink:href="/carbon-icons/bluemix-icons.svg#icon--caret--down"></use>
</svg>
</th>
<th class="bx--table-header bx--table-sort" data-event="sort">
Last Name
<svg class="bx--table-sort__svg">
<use xlink:href="/@console/bluemix-icons/bluemix-icons.svg#icon--caret--down"></use>
<use xlink:href="/carbon-icons/bluemix-icons.svg#icon--caret--down"></use>
</svg>
</th>
<th class="bx--table-header bx--table-sort" data-event="sort">
House
<svg class="bx--table-sort__svg">
<use xlink:href="/@console/bluemix-icons/bluemix-icons.svg#icon--caret--down"></use>
<use xlink:href="/carbon-icons/bluemix-icons.svg#icon--caret--down"></use>
</svg>
</th>
</tr>
Expand Down
Loading

0 comments on commit 85cabc4

Please sign in to comment.