Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[link] Update focus style #333

Closed
half5cat opened this issue Jun 26, 2020 · 6 comments
Closed

[link] Update focus style #333

half5cat opened this issue Jun 26, 2020 · 6 comments

Comments

@half5cat
Copy link

The focus style from the Sketch Kit is not reflecting the actual behaviour: https://www.carbondesignsystem.com/components/link/usage and https://react.carbondesignsystem.com/?path=/story/link--default

This is what the sketch file contains:
image

And this is how it should be:
image

This also affects the breadcrumbs styles.

@stale
Copy link

stale bot commented Aug 21, 2020

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the inactive label Aug 21, 2020
@stale
Copy link

stale bot commented Sep 26, 2020

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the inactive label Sep 26, 2020
@stale
Copy link

stale bot commented Nov 5, 2020

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the inactive label Nov 5, 2020
@stale
Copy link

stale bot commented Dec 19, 2020

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the inactive label Dec 19, 2020
@laurenmrice laurenmrice self-assigned this Jan 11, 2021
@laurenmrice
Copy link
Member

laurenmrice commented Jan 12, 2021

Breadcrumb

  • White theme
  • Gray 10 theme
  • Gray 90 theme
  • Gray 100 theme

Link

  • White theme
  • Gray 10 theme
  • Gray 90 theme
  • Gray 100 theme

@laurenmrice
Copy link
Member

Fixed! Will be available in the next update 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants