Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dropdown, Combobox & Multiselect]: Update Figma kit focus states #874

Closed
5 tasks done
Kritvi-bhatia17 opened this issue Oct 28, 2024 · 0 comments
Closed
5 tasks done

Comments

@Kritvi-bhatia17
Copy link

Kritvi-bhatia17 commented Oct 28, 2024

Acceptance criteria

Background: Michael highlighted some differences in interaction and behavior across several Dropdown variants, including Combobox, Multiselect, Filterable Multiselect, Multiselect with Select All, and Fluid Dropdown with no default option. Specifically, a few of the focus states need adjustments. We discussed this further in the CAG call (Oct 21).

Tasks

  • Update the focus states in the Figma kit based on this (reviewed by Michael) , prioritizing mouse/Enter key interactions, as these are most commonly used.
  • Fix the placeholder value bugs in some places

Review

  • Accessibility expert (Michael)
  • Carbon designer (Lauren)

  • Additionally, create an issue to update Storybook to reflect both mouse/Enter key interactions and Down Arrow keyboard interactions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment