Skip to content

Commit

Permalink
test(e2e): add PublicAPI tests and use metadata for icon tests (#5846)
Browse files Browse the repository at this point in the history
* chore(github): update CODEOWNERS syntax for PublicAPI files

* test(e2e): add PublicAPI tests and use metadata for icon tests

* fix(icons): add registry to exports and check for duplicate sizes

* test(matchers): defer AAT module resolution until called

* docs(icon-build-helpers): add jsdoc for load export

* test(e2e): add ESM files to exports test

* chore(test): update paths for registry

* chore(github): update CODEOWNERS comments

* fix(icon-build-helpers): set namespace for pictograms

* fix(pictograms): add main and module fields to package.json

* test(e2e): add e2e tests for pictograms and pictograms-react

Co-authored-by: TJ Egan <[email protected]>
  • Loading branch information
joshblack and tw15egan committed Apr 16, 2020
1 parent 9a464c8 commit af67df5
Show file tree
Hide file tree
Showing 25 changed files with 9,487 additions and 43 deletions.
7 changes: 3 additions & 4 deletions CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
# Brand
/packages/colors/artifacts/ @lisalind-ibm

# Release team should be notified of Public API changes in the following
# packages
/packages/react/__tests__/PublicAPI-test.js @carbon-design-system/release @carbon-design-system/developers-system
/packages/react/__tests__/__snapshots__/PublicAPI-test.js.snap @carbon-design-system/release @carbon-design-system/developers-system
# Release team should be notified of Public API changes in the system
**/PublicAPI-test.js @carbon-design-system/release @carbon-design-system/developers-system
**/PublicAPI-test.js.snap @carbon-design-system/release @carbon-design-system/developers-system
18 changes: 18 additions & 0 deletions e2e/icons-react/PublicAPI-test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
/**
* Copyright IBM Corp. 2018, 2018
*
* This source code is licensed under the Apache-2.0 license found in the
* LICENSE file in the root directory of this source tree.
*
* @jest-environment node
*/

'use strict';

const CarbonIconsReact = require('@carbon/icons-react');

describe('@carbon/icons-react', () => {
it('should not update exports without a semver change', () => {
expect(Object.keys(CarbonIconsReact).sort()).toMatchSnapshot();
});
});
Loading

0 comments on commit af67df5

Please sign in to comment.