Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: NumberInputSkeleton doesn't support helper text or sizes #16717

Closed
alisonjoseph opened this issue Jun 7, 2024 · 2 comments · Fixed by #17825
Closed

[Bug]: NumberInputSkeleton doesn't support helper text or sizes #16717

alisonjoseph opened this issue Jun 7, 2024 · 2 comments · Fixed by #17825

Comments

@alisonjoseph
Copy link
Member

alisonjoseph commented Jun 7, 2024

Compare NumberInputSkeleton to Figma.

  • Add size props
  • Add show/hide helpertext

Question for @carbon-design-system/design do we want to add the the +/- buttons to the coded skeleton state?

@riddhybansal
Copy link
Contributor

Hey @laurenmrice @alina-jacob Could you help with this ?

@alina-jacob
Copy link
Member

alina-jacob commented Aug 14, 2024

Hi @riddhybansal, in Figma, the skeleton state has the +/- button for default component across all sizes but the skeleton state doesn't have the +/- button in the fluid component.

There are similar inconsistencies across Figma and storybook in other components and their skeleton states as well, so not sure what the correct representation is in a larger context. Have created an issue for the same here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
4 participants