Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[web-components]: add file extension to icon imports #18532

Open
kennylam opened this issue Feb 5, 2025 · 0 comments · May be fixed by #18536
Open

[web-components]: add file extension to icon imports #18532

kennylam opened this issue Feb 5, 2025 · 0 comments · May be fixed by #18536
Assignees
@kennylam
Labels
package: @carbon/web-components @carbon/web-components

Comments

@kennylam
Copy link
Member

kennylam commented Feb 5, 2025

There are still some icon imports missing file extensions which can cause build/bundling errors, e.g.

carbon/packages/web-components/src/components/progress-indicator/progress-step-skeleton.ts

Line 14 in 3727760

import CircleDash from '@carbon/icons/lib/circle-dash/16';

@kennylam kennylam added the package: @carbon/web-components @carbon/web-components label Feb 5, 2025
@kennylam kennylam self-assigned this Feb 5, 2025
@kennylam kennylam moved this to 🏗 In Progress in Design System Feb 5, 2025
@kennylam kennylam linked a pull request Feb 6, 2025 that will close this issue
Open
@kennylam kennylam moved this from 🏗 In Progress to 🚦 In Review in Design System Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kennylam kennylam

Labels
package: @carbon/web-components @carbon/web-components
Projects
Design System
Status: 🚦 In Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(icons): add file extension to icon imports kennylam/carbon
1 participant
@kennylam