-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design Layout of resources for automatic elements library Generation #2436
Comments
TemplateSketch file example: https://ibm.box.com/s/pdoa77z48q51z8rp7mb7up8bj2xlnii0 IconsAll icons should be symbols File structure
Naming
CategoriesWe are going to keep the IDL category in the Sketch kit so icons are easier to find. ColorsThemesTypeQuestions
|
I believe we can!
Good question, I think we can do shared styles (not sure if that helps) |
@joshblack I've updated the comment above just fyi |
Thanks @aagonzales! Do we have access to categories yet for the icons btw? |
@joshblack "Do we have access to categories yet for the icons btw?" do you mean in the metadata yml? |
@chrisconnors-ibm I don't think it's in the metadata yet, unfortunately. Just saw that the icons above are in categories but I'm not sure where that information lives. We only have example ones in metadata: https://github.com/carbon-design-system/carbon-elements/blob/master/packages/icons/metadata.yml#L6 |
you can see their classification here: https://www.ibm.com/design/language/elements/icon-library That's what's reflected in the existing IDL library too. So how would we encode each icon to be in one (1) category? should that be a prop in the yml file? |
Yeah, there is a |
here's an issue to add the categories for each icon. #2672 |
Closing this as this work item is done 👍 |
Design the layout of the library elements as we want them to be generated via #484
The text was updated successfully, but these errors were encountered: