Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breadcrumbs]: allow React component to accept additional attributes #5107

Closed
jendowns opened this issue Jan 20, 2020 · 0 comments · Fixed by #5108
Closed

[Breadcrumbs]: allow React component to accept additional attributes #5107

jendowns opened this issue Jan 20, 2020 · 0 comments · Fixed by #5108

Comments

@jendowns
Copy link
Contributor

Summary

Currently the Breadcrumbs React component does not have a spread attribute, so a user cannot pass in anything outside of the defined props to be rendered, like an id.

Justification

I think it is reasonable to expect an end user to want to pass in an id attribute, for example, to a component and have that be rendered in the DOM. There are also data attributes that different application may need to pass in.

By adding a spread attribute to the component, Breadcrumbs would be able to accept these additional attributes.

Available extra resources

I can help with this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant