Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataTable with selection]: Link component fails color contrast if row is selected #6845

Closed
abbeyhrt opened this issue Sep 15, 2020 · 1 comment · Fixed by #7770
Closed

[DataTable with selection]: Link component fails color contrast if row is selected #6845

abbeyhrt opened this issue Sep 15, 2020 · 1 comment · Fixed by #7770
Labels
component: data-table component: link type: a11y ♿

Comments

@abbeyhrt
Copy link
Contributor

Found a small accessibility issue when DataTable and Link are used together. If a Link is used anywhere in a Datatable's row with selection enabled, the Link will fail color contrast when that row is selected:

Screen Shot 2020-09-15 at 3 09 25 PM

Violation:
Screen Shot 2020-09-15 at 3 09 35 PM
@abbeyhrt
Copy link
Contributor Author

abbeyhrt commented Feb 2, 2021

@jeanservaas or @aagonzales Would you have any recommendations for what token should be used so that Link has enough contrast?

@tw15egan tw15egan mentioned this issue Feb 5, 2021
Closed
@tay1orjones tay1orjones mentioned this issue Feb 9, 2021
Merged
@kodiakhq kodiakhq bot closed this as completed in #7770 Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: data-table component: link type: a11y ♿
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(theme): add link02 token tay1orjones/carbon
2 participants
@emyarod @abbeyhrt