Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dropdown] component audit bugs #7325

Closed
9 of 15 tasks
laurenmrice opened this issue Nov 20, 2020 · 1 comment
Closed
9 of 15 tasks

[dropdown] component audit bugs #7325

laurenmrice opened this issue Nov 20, 2020 · 1 comment

Comments

@laurenmrice
Copy link
Member

laurenmrice commented Nov 20, 2020

Assorted bugs that were found from the component audit for dropdown, combobox and mutli-select.

Dropdown

  • Light prop: hover-light-ui color token needs to be used for the hover states.
  • Warning state: warning icon needs a black inner fill for all themes.
  • Invalid state: alert icon needs a black inner fill for dark themes.
  • Inline variant: is not available to interact with in the playground story.

Combobox

  • Light prop: hover-light-ui color token needs to be used for the hover states of the options in the menu.
  • Warning state: there is currently no warning state for combobox, but it should be added.
  • Invalid state: alert icon needs a black inner fill for dark themes.
  • The top input field should not have a hover color change, only a cursor change to type.
  • The close icon should be icon-01.

Multi-select

  • Light prop: hover-light-ui color token needs to be used for the hover states.
  • Warning state: warning icon needs a black inner fill for all themes.
  • Invalid state: alert icon needs a black inner fill for dark themes.
  • The entire tag right now is clickable which clear the selection. Only the close icon in the tag should clear the items selected.
  • Tag hover color for the close icon needs to be inverse-hover-ui color token.
  • Tag focus border needs to be around the close icon, not the entire tag. The focus color should be inverse-focus-ui color token.
@tw15egan
Copy link
Collaborator

Seems like the outstanding issues are resolved with #8092

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants