Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore margin-bottom to labels inside input components #9947

Closed
tay1orjones opened this issue Oct 26, 2021 · 0 comments · Fixed by #10028
Closed

Restore margin-bottom to labels inside input components #9947

tay1orjones opened this issue Oct 26, 2021 · 0 comments · Fixed by #10028
Assignees
@tay1orjones
Milestone
v11 Beta 3

Comments

@tay1orjones
Copy link
Member

The margin-bottom on .#{$prefix}--label was recently removed in #9830. This removed margin from FormLabel, but also removed all margin from labels inside TextInput, RadioButton, etc.

This issue is to make sure that the form labels internal to components have margin built in, while the FormLabel component does not have any margin built in.
@tay1orjones tay1orjones self-assigned this Oct 26, 2021
@tay1orjones tay1orjones mentioned this issue Oct 26, 2021
Closed
3 tasks
@jnm2377 jnm2377 mentioned this issue Oct 26, 2021
Merged
@joshblack joshblack moved this to Backlog in Design System Oct 29, 2021
@tay1orjones tay1orjones mentioned this issue Nov 1, 2021
Closed
61 tasks
@tay1orjones tay1orjones added this to the v11 Beta 3 milestone Nov 2, 2021
@tay1orjones tay1orjones mentioned this issue Nov 2, 2021
Merged
Repository owner moved this from Backlog to Done in Design System Nov 2, 2021
@tay1orjones tay1orjones mentioned this issue Nov 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tay1orjones tay1orjones

Labels
None yet
Projects
Design System
Archived in project
Milestone
v11 Beta 3
Development

Successfully merging a pull request may close this issue.

fix(form): restore label margin, remove margin from FormLabel only tay1orjones/carbon
1 participant
@tay1orjones