feat(react): added input change callback to multiselect filterable #11415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DCO Assistant Lite bot All contributors have signed the DCO. |
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
I have read the DCO document and I hereby sign the DCO. |
|
I have read the DCO document and I hereby sign the DCO. |
|
recheck |
tay1orjones
approved these changes
May 13, 2022
joshblack
approved these changes
May 16, 2022
joshblack
reviewed
May 16, 2022
packages/react/src/components/MultiSelect/next/FilterableMultiSelect.js
Outdated
Show resolved
Hide resolved
…nerS/carbon into tanner_addInputChangeMultiselectProp
tay1orjones
added a commit
to tay1orjones/carbon
that referenced
this pull request
Jun 27, 2022
…arbon-design-system#11415) * feat(react): added input change callback to multiselect filterable * chore(react): removed story changes for previous version * chore(project): update snaps * chore(react): updated handleOnInputValueChange to remove type param Co-authored-by: Taylor Jones <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
kodiakhq bot
added a commit
that referenced
this pull request
Jun 27, 2022
…11690) * feat(react): added input change callback to multiselect filterable (#11415) * feat(react): added input change callback to multiselect filterable * chore(react): removed story changes for previous version * chore(project): update snaps * chore(react): updated handleOnInputValueChange to remove type param Co-authored-by: Taylor Jones <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * chore(project): update caniuse-lite, browserslist db Co-authored-by: Tanner Summers <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
kennylam
added a commit
to kennylam/carbon
that referenced
this pull request
Jul 30, 2024
…ge-cwc-v2.1.2 chore(merge): merge `release-cwc/v2.1.2` into `main`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
N/A
Changelog
New
Added a new callback for users can get the input as it is being typed.
Due to a carbon 10 -> carbon11 update on the filterable component, it broken some
refinfo for our service in production and this needs to be fixed sooner than laterTesting / Reviewing
Wanting to test in storybook for current action detection but currently having issues with that