Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(structuredlist): expose isCondensed and isFlush props #11431

Merged

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented May 18, 2022

Closes #11432

Originally surfaced in slack

Changelog

New

  • Expose isCondensed and isFlush props for StructuredListWrapper
  • Add tests for these props

Changed

  • Update playground story to have controls for these props

Testing / Reviewing

  • Look at the structuredlist playground story, try isFlush and isCondensed and selection props and ensure they all interact together fine without defects.

@tay1orjones tay1orjones requested a review from a team as a code owner May 18, 2022 15:27
@tay1orjones tay1orjones requested review from abbeyhrt and jnm2377 May 18, 2022 15:27
@tay1orjones tay1orjones self-assigned this May 18, 2022
@tay1orjones tay1orjones added this to the 2022 Q2 milestone May 18, 2022
@netlify
Copy link

netlify bot commented May 18, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5d935cb
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/628567674b6dcd0008561589
😎 Deploy Preview https://deploy-preview-11431--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 18, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 5d935cb
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/628567671e70cc000854b5ad
😎 Deploy Preview https://deploy-preview-11431--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tay1orjones
Copy link
Member Author

Have been notified there's an additional fix needed - the focus states aren't showing up on the rows. Will investigate and update this PR.

@tay1orjones tay1orjones marked this pull request as draft May 18, 2022 16:53
@tay1orjones
Copy link
Member Author

Rows not getting focus when clicked is the expected interaction. (#8172 (comment), #8172 (comment))

They do get focus when tabbed into though and can be changed via up and down arrows. So there's nothing more to address here. Marking as ready for review.

@tay1orjones tay1orjones marked this pull request as ready for review May 18, 2022 18:41
@tay1orjones tay1orjones requested review from dakahn and joshblack May 18, 2022 18:42
@kodiakhq kodiakhq bot merged commit 09bad3d into carbon-design-system:main May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: StructuredListWrapper needs to support the condensed and selected options
3 participants