Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form-group): remove default hasMargin prop #11435

Merged
merged 6 commits into from
May 25, 2022
Merged

Conversation

joshblack
Copy link
Contributor

This PR removes the hasMargin prop from defaultProps in FormGroup. This prop used to be available in v10 but is no longer used as part of the className in v11

Changelog

New

Changed

Removed

  • Remove the defaultProp value for hasMargin

@joshblack joshblack requested a review from a team as a code owner May 18, 2022 20:24
@joshblack joshblack requested review from abbeyhrt and dakahn May 18, 2022 20:24
@netlify
Copy link

netlify bot commented May 18, 2022

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 6d5f9d0
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/628e9cd31576fb0008def7db
😎 Deploy Preview https://deploy-preview-11435--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 18, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 6d5f9d0
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/628e9cd3a8df3a0008811c08
😎 Deploy Preview https://deploy-preview-11435--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@joshblack
Copy link
Contributor Author

@amtoussam it should be good to go since that is the old v10 story, let me know if I'm misunderstanding though!

@joshblack
Copy link
Contributor Author

bump @dakahn when you get a sec

@kodiakhq kodiakhq bot merged commit 2a42de4 into main May 25, 2022
@kodiakhq kodiakhq bot deleted the joshblack-patch-2 branch May 25, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants