Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CopyButton): removes additional fill on click animation #11436

Merged
merged 4 commits into from
May 20, 2022

Conversation

jnm2377
Copy link
Contributor

@jnm2377 jnm2377 commented May 18, 2022

Closes #11410

Changelog

  • Removes border that was getting added on pseudo element for animation on click

Testing / Reviewing

  • Go to CopyButton story
    • switch to darker themes (to be able to see the fill easier, even though it exists on all themes)
    • click the copy button
    • animation should work without the additional fill in the icon
  • Test out the same way for CodeSnippet multi + single stories

@jnm2377 jnm2377 requested a review from a team as a code owner May 18, 2022 20:34
@jnm2377 jnm2377 requested review from tay1orjones and joshblack May 18, 2022 20:34
@netlify
Copy link

netlify bot commented May 18, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit de90a06
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/6287e25b8c1cba0008ba43c4
😎 Deploy Preview https://deploy-preview-11436--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 18, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit de90a06
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6287e25b2f3b6b0008e561a5
😎 Deploy Preview https://deploy-preview-11436--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodiakhq kodiakhq bot merged commit aac9350 into carbon-design-system:main May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Copy button in Code snippet
3 participants