feat(react): add autoAlign feature to popover
#11508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jnm2377
reviewed
May 31, 2022
|
This looks great! 🔥 Left some comments about maybe adding a few more contextual comments for maintainers, but it's not a dealbreaker. The story seems to be working great. I'm wondering if we should add some tests around this functionality, though? |
|
@jnm2377 Thanks for looking through it! I think the only way to test it is through a VRT test. Since it's just a visual change, there's no way really to meaningfully test this with RTL. There aren't any VRT tests for Popover yet and I asked @joshblack and he said to hold off on adding one for this variant until it does |
jnm2377
approved these changes
May 31, 2022
joshblack
suggested changes
Jun 1, 2022
abbeyhrt
requested review from
joshblack and
a team
and removed request for
a team
tay1orjones
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11385
Adds
autoAlignprop and corresponding feature to Popover component. Popover withautoAlign={true}will only work on first render so resize and scroll events will currently have no impact on the positioning.Testing / Reviewing
Review code to make sure the approach is okay and go to the 'Automate' story for Popover to see if it is visible in all four instances