Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sidenavdetails): spread additional props on underlying container #11692

Merged

Conversation

tay1orjones
Copy link
Member

Closes #8449

Changelog

New

  • spread additional props to underlying container via ...rest

Testing / Reviewing

  • Ensure no regressions with SideNavDetails within UIShell

@tay1orjones tay1orjones requested a review from a team as a code owner June 27, 2022 21:38
@tay1orjones tay1orjones requested review from abbeyhrt and jnm2377 June 27, 2022 21:38
@tay1orjones tay1orjones changed the title feat(sidenavdetails): spread additional props to underlying container feat(sidenavdetails): spread additional props on underlying container Jun 27, 2022
@netlify
Copy link

netlify bot commented Jun 27, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit a964e4b
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/62c703b3df0f54000aff130c
😎 Deploy Preview https://deploy-preview-11692--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 27, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a964e4b
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/62c703b3dd210a0009e229f8
😎 Deploy Preview https://deploy-preview-11692--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodiakhq kodiakhq bot merged commit 2b4ffd2 into carbon-design-system:main Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

SideNavDetails pass additional props to underlying container
4 participants