-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add testing for Switcher, SwitcherDivider and SwitcherItem #13342
Merged
kodiakhq
merged 3 commits into
carbon-design-system:main
from
francinelucca:12859-add-tests-for-switcher-switcherdivider-switcheritem
Mar 14, 2023
Merged
test: add testing for Switcher, SwitcherDivider and SwitcherItem #13342
kodiakhq
merged 3 commits into
carbon-design-system:main
from
francinelucca:12859-add-tests-for-switcher-switcherdivider-switcheritem
Mar 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francinelucca
added
status: ready for review 👀
and removed
status: ready to merge 🎉
labels
Mar 13, 2023
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
alisonjoseph
approved these changes
Mar 14, 2023
andreancardona
approved these changes
Mar 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just need to update copyright header :)
andreancardona
approved these changes
Mar 14, 2023
andreancardona
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: one more review 👀
labels
Mar 14, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12859
Adds testing for
Switcher
,SwitcherDivider
andSwitcherItem
.Also refactors test generator script to generate IBM Copyright header using current year.
Changelog
New
Switcher
SwitcherDivider
SwitcherItem
Testing / Reviewing
Should test every prop in
Switcher
,SwitcherItem
andSwitcherDivider
and all tests should pass