Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: i changed the popover declaration for the docs to be shown #14666

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

azizChebbi
Copy link
Contributor

Closes #14034

I have changed the Popover component declaration, the problem seems to be related to the type assertion in typescript.

Changelog

New

  • The Popover docs are well displayed.

@azizChebbi azizChebbi requested a review from a team as a code owner September 16, 2023 13:14
@netlify
Copy link

netlify bot commented Sep 16, 2023

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 358ce32
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6505aa38142d340008712532
😎 Deploy Preview https://deploy-preview-14666--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 16, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 358ce32
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6505aa38142d340008712534
😎 Deploy Preview https://deploy-preview-14666--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@azizChebbi azizChebbi closed this Sep 16, 2023
@azizChebbi azizChebbi reopened this Sep 16, 2023
Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! It is working as expected now!

Thank you! 🚀

@tw15egan tw15egan added this pull request to the merge queue Sep 18, 2023
Merged via the queue into carbon-design-system:main with commit 7d7ebb2 Sep 18, 2023
29 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Popover storybook - Broken component API
4 participants