Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toast-notification): restore bottom margin on details container #17578

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Sep 25, 2024

Closes #17523

This PR restores the bottom margin on the toast notification to the details div instead of the caption or subtitle. It also adds some visual regression tests

Changelog

New

  • component test snapshots

Changed

  • toast notification bottom margin placement

Testing / Reviewing

Confirm that the bottom margin of the toast notification does not collapse with different combinations of titles, subtitles, and captions of different length

@emyarod emyarod requested a review from a team as a code owner September 25, 2024 16:52
Copy link

netlify bot commented Sep 25, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 3287460
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66f527744460990008221687
😎 Deploy Preview https://deploy-preview-17578--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 25, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3287460
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66f52774e2219b00089c1489
😎 Deploy Preview https://deploy-preview-17578--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.03%. Comparing base (52b7061) to head (3287460).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17578   +/-   ##
=======================================
  Coverage   77.03%   77.03%           
=======================================
  Files         408      408           
  Lines       13993    13993           
  Branches     4353     4349    -4     
=======================================
  Hits        10779    10779           
- Misses       3041     3042    +1     
+ Partials      173      172    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@2nikhiltom 2nikhiltom added this pull request to the merge queue Sep 30, 2024
Merged via the queue into carbon-design-system:main with commit 647881b Sep 30, 2024
35 of 36 checks passed
@emyarod emyarod deleted the 17523-fix/toast-notifications-bottom-margin branch October 1, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Toast notifications without a subtitle are missing bottom margin
5 participants