-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(toast-notification): restore bottom margin on details container #17578
fix(toast-notification): restore bottom margin on details container #17578
Conversation
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17578 +/- ##
=======================================
Coverage 77.03% 77.03%
=======================================
Files 408 408
Lines 13993 13993
Branches 4353 4349 -4
=======================================
Hits 10779 10779
- Misses 3041 3042 +1
+ Partials 173 172 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
647881b
Closes #17523
This PR restores the bottom margin on the toast notification to the details div instead of the caption or subtitle. It also adds some visual regression tests
Changelog
New
Changed
Testing / Reviewing
Confirm that the bottom margin of the toast notification does not collapse with different combinations of titles, subtitles, and captions of different length