Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added typescript types to fluid multiselect #17583

Conversation

riddhybansal
Copy link
Contributor

Closes #17363

  • Added Typescript component to Flluid Multiselect and its skeleton state
  • Deprecated 'isFilterable' prop
  • Added a new component called FluidFilterableMultiselect
  • Converted index.js to index.tsx
  • Added missing type imports from different components

Testing / Reviewing

  • FluidMultiSelect should work as intended.

@riddhybansal riddhybansal requested a review from a team as a code owner September 26, 2024 10:06
Copy link

netlify bot commented Sep 26, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit ca168c6
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66f6df453e0f760008baae04
😎 Deploy Preview https://deploy-preview-17583--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 26, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ca168c6
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66f6df4513ba3800088ddd40
😎 Deploy Preview https://deploy-preview-17583--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 76.98%. Comparing base (5020449) to head (ca168c6).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
...c/components/FluidMultiSelect/FluidMultiSelect.tsx 22.22% 7 Missing ⚠️
...ts/FluidMultiSelect/FluidFilterableMultiSelect.tsx 0.00% 1 Missing ⚠️
...nts/FluidMultiSelect/FluidMultiSelect.Skeleton.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17583      +/-   ##
==========================================
- Coverage   77.03%   76.98%   -0.05%     
==========================================
  Files         408      409       +1     
  Lines       13993    14001       +8     
  Branches     4321     4350      +29     
==========================================
  Hits        10779    10779              
- Misses       3041     3050       +9     
+ Partials      173      172       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kennylam kennylam enabled auto-merge October 1, 2024 13:45
@kennylam kennylam added this pull request to the merge queue Oct 1, 2024
Merged via the queue into carbon-design-system:main with commit 9d5eea1 Oct 1, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FluidMultiSelect
4 participants