Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notification): background-warning-token to use yellow10 #17621

Conversation

ariellalgilmore
Copy link
Member

@ariellalgilmore ariellalgilmore commented Oct 1, 2024

Closes #17586

update notification-background-warning-token to use yellow10
Screenshot 2024-09-30 at 5 21 18 PM
Screenshot 2024-09-30 at 5 21 57 PM

Changelog

Changed

  • using yellow10 now instead of mixing colors

Testing / Reviewing

  • go to the playground of notification stories
  • turn on low-contrast
  • set kind to warning
  • confirm correct color in the background

@ariellalgilmore ariellalgilmore requested a review from a team as a code owner October 1, 2024 00:18
Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit ddf5ccd
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66fb3fc9078e6f00089f50a3
😎 Deploy Preview https://deploy-preview-17621--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ddf5ccd
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66fb3fc91650db0008ef526f
😎 Deploy Preview https://deploy-preview-17621--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.03%. Comparing base (6bd017d) to head (ddf5ccd).
Report is 16 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17621   +/-   ##
=======================================
  Coverage   77.03%   77.03%           
=======================================
  Files         408      408           
  Lines       13993    13993           
  Branches     4349     4348    -1     
=======================================
  Hits        10779    10779           
- Misses       3041     3042    +1     
+ Partials      173      172    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kennylam kennylam added this pull request to the merge queue Oct 1, 2024
Merged via the queue into carbon-design-system:main with commit c0b1af5 Oct 1, 2024
36 checks passed
@ariellalgilmore ariellalgilmore deleted the fix/notification-background-warning-token branch October 1, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Update notification-background-warning token
3 participants