From 95a4e35ef11cfba305f586dffa5535614e22f210 Mon Sep 17 00:00:00 2001 From: guidari Date: Fri, 1 Nov 2024 10:36:50 -0300 Subject: [PATCH 1/5] fix: fixed hover on multiselect --- packages/styles/scss/components/tag/_tag.scss | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/packages/styles/scss/components/tag/_tag.scss b/packages/styles/scss/components/tag/_tag.scss index e9cd524b492c..098e5ae803e7 100644 --- a/packages/styles/scss/components/tag/_tag.scss +++ b/packages/styles/scss/components/tag/_tag.scss @@ -246,6 +246,14 @@ ); } + .#{$prefix}--multi-select--readonly + .#{$prefix}--tag--high-contrast:not(.#{$prefix}--tag--operational) + .#{$prefix}--tag__close-icon { + &:hover { + background-color: transparent; + } + } + .#{$prefix}--tag--outline:not(.#{$prefix}--tag--operational):not(span):not( [disabled] ) { @@ -303,8 +311,7 @@ color: currentColor; cursor: pointer; inline-size: layout.size('height'); - transition: - background-color $duration-fast-01 motion(standard, productive), + transition: background-color $duration-fast-01 motion(standard, productive), box-shadow $duration-fast-01 motion(standard, productive); svg { From 3edf349d0b391da2368140ee11d2083dd5a1c6d9 Mon Sep 17 00:00:00 2001 From: Guilherme Datilio Ribeiro Date: Fri, 1 Nov 2024 11:15:49 -0300 Subject: [PATCH 2/5] yarn format --- packages/styles/scss/components/tag/_tag.scss | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/styles/scss/components/tag/_tag.scss b/packages/styles/scss/components/tag/_tag.scss index 098e5ae803e7..5d64658850fc 100644 --- a/packages/styles/scss/components/tag/_tag.scss +++ b/packages/styles/scss/components/tag/_tag.scss @@ -311,7 +311,8 @@ color: currentColor; cursor: pointer; inline-size: layout.size('height'); - transition: background-color $duration-fast-01 motion(standard, productive), + transition: + background-color $duration-fast-01 motion(standard, productive), box-shadow $duration-fast-01 motion(standard, productive); svg { From bad2efcf86236e3b6baaaf459625b0b310f1c256 Mon Sep 17 00:00:00 2001 From: Guilherme Datilio Ribeiro Date: Fri, 1 Nov 2024 11:16:21 -0300 Subject: [PATCH 3/5] Update _tag.scss --- packages/styles/scss/components/tag/_tag.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/styles/scss/components/tag/_tag.scss b/packages/styles/scss/components/tag/_tag.scss index 5d64658850fc..af96f99a9d8b 100644 --- a/packages/styles/scss/components/tag/_tag.scss +++ b/packages/styles/scss/components/tag/_tag.scss @@ -311,7 +311,7 @@ color: currentColor; cursor: pointer; inline-size: layout.size('height'); - transition: + transition: background-color $duration-fast-01 motion(standard, productive), box-shadow $duration-fast-01 motion(standard, productive); From 4f5066081d7527c0b69163af7f9f105d0432d81b Mon Sep 17 00:00:00 2001 From: guidari Date: Wed, 6 Nov 2024 11:15:49 -0300 Subject: [PATCH 4/5] fix: fixed colors and hover --- packages/styles/scss/components/list-box/_list-box.scss | 7 +++++-- .../styles/scss/components/multiselect/_multiselect.scss | 2 +- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/packages/styles/scss/components/list-box/_list-box.scss b/packages/styles/scss/components/list-box/_list-box.scss index 3ff3d1f0ec4a..d87cda8b3fb1 100644 --- a/packages/styles/scss/components/list-box/_list-box.scss +++ b/packages/styles/scss/components/list-box/_list-box.scss @@ -95,6 +95,10 @@ $list-box-menu-width: convert.to-rem(300px); } } + .#{$prefix}--multi-select.#{$prefix}--multi-select--readonly.#{$prefix}--list-box { + cursor: default; + } + .#{$prefix}--list-box--lg { block-size: convert.to-rem(48px); max-block-size: convert.to-rem(48px); @@ -669,8 +673,7 @@ $list-box-menu-width: convert.to-rem(300px); padding-inline-end: $spacing-06; text-decoration: none; text-overflow: ellipsis; - transition: - border-color $duration-fast-01 motion(standard, productive), + transition: border-color $duration-fast-01 motion(standard, productive), color $duration-fast-01 motion(standard, productive); white-space: nowrap; diff --git a/packages/styles/scss/components/multiselect/_multiselect.scss b/packages/styles/scss/components/multiselect/_multiselect.scss index a9acb0c08573..fcdb39f3cc2e 100644 --- a/packages/styles/scss/components/multiselect/_multiselect.scss +++ b/packages/styles/scss/components/multiselect/_multiselect.scss @@ -201,7 +201,7 @@ .#{$prefix}--multi-select.#{$prefix}--multi-select--readonly .#{$prefix}--tag--filter { - box-shadow: 0 0 0 1px $background-inverse; + box-shadow: 0 0 0 1px $border-subtle; } .#{$prefix}--multi-select.#{$prefix}--multi-select--readonly From d684e69f0a2eddf9b9d9f4195389389edfcee309 Mon Sep 17 00:00:00 2001 From: Guilherme Datilio Ribeiro Date: Wed, 6 Nov 2024 11:17:58 -0300 Subject: [PATCH 5/5] Update _list-box.scss --- packages/styles/scss/components/list-box/_list-box.scss | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/styles/scss/components/list-box/_list-box.scss b/packages/styles/scss/components/list-box/_list-box.scss index d87cda8b3fb1..31849877346a 100644 --- a/packages/styles/scss/components/list-box/_list-box.scss +++ b/packages/styles/scss/components/list-box/_list-box.scss @@ -673,7 +673,8 @@ $list-box-menu-width: convert.to-rem(300px); padding-inline-end: $spacing-06; text-decoration: none; text-overflow: ellipsis; - transition: border-color $duration-fast-01 motion(standard, productive), + transition: + border-color $duration-fast-01 motion(standard, productive), color $duration-fast-01 motion(standard, productive); white-space: nowrap;