Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css-grid): various bugfixes, first docs pass #8797

Merged
merged 11 commits into from
Jun 8, 2021
Merged

fix(css-grid): various bugfixes, first docs pass #8797

merged 11 commits into from
Jun 8, 2021

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented May 28, 2021 •
edited
Loading

Part of #8556

First pass at CSS Grid stories and docs. Also a few bugfixes to the css grid implementation; mixed mode gutters, add aspect ratio, among others.

Changelog

New

  • New stories covering various parts of CSS Grid
  • CSS Grid mdx storybook docs
  • Configured storybook breakpoint switcher to use CDS defined breakpoints

Changed

  • CSS Grid styling for mixed mode gutters, max width, among other small fixes

Testing / Reviewing

Spin up the new storybook and check it out

grid.stories.mov

@tay1orjones tay1orjones requested a review from a team as a code owner May 28, 2021 16:52
@netlify
Copy link

netlify bot commented May 28, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 3265327

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60b11fb6f001080008a01ee6

😎 Browse the preview: https://deploy-preview-8797--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented May 28, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: f11a28c

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60bf9c66164b3b000808a34c

😎 Browse the preview: https://deploy-preview-8797--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented May 28, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 3265327

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60b11fb673ac9e00074ad4e5

😎 Browse the preview: https://deploy-preview-8797--carbon-components-react.netlify.app/iframe

@netlify
Copy link

netlify bot commented May 28, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: f11a28c

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60bf9c66da0dab0007fa340a

😎 Browse the preview: https://deploy-preview-8797--carbon-components-react.netlify.app/iframe

joshblack
joshblack suggested changes May 28, 2021
View reviewed changes
Copy link
Contributor

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Left a couple of QOL fixes/updates

One note for the span classes, feel free to update to have the behavior match CSS Grid instead of our old behavior if it makes sense. I think aligning with CSS Grid terminology instead of having our implementation try and map back to our v10 work makes a ton of sense 👍

packages/carbon-react/.storybook/main.js Outdated Show resolved Hide resolved
packages/grid/examples/css-grid/src/pages/layouts.js Outdated Show resolved Hide resolved
packages/grid/scss/modules/_css-grid.scss Outdated Show resolved Hide resolved
@tay1orjones
Copy link
Member Author

tay1orjones commented Jun 3, 2021 •
edited
Loading

@joshblack thanks! I revised the span/offset classes to match CSS Grid more appropriately, improved the offset story, addressed the other feedback items, and updated the import to use the normal entrypoint 👍

@tay1orjones tay1orjones requested a review from joshblack June 3, 2021 01:45
@kodiakhq kodiakhq bot merged commit 3a62e3d into carbon-design-system:main Jun 8, 2021
@jnm2377 jnm2377 mentioned this pull request Jun 9, 2021
Closed
22 tasks
emyarod pushed a commit to emyarod/carbon that referenced this pull request Jun 10, 2021
@tay1orjones @kodiakhq @emyarod
fix(css-grid): various bugfixes, first docs pass (carbon-design-syste…
e7f6a24 
…m#8797)

* wip: check in work

* fix(css-grid): various bugfixes, first docs pass

* chore(wip): check in work based on review feedback

* fix(grid): correct offset styling and available classes

* chore: update snapshot

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@tw15egan tw15egan mentioned this pull request Jun 30, 2021
Closed
48 tasks
@tay1orjones tay1orjones mentioned this pull request Jul 12, 2021
Closed
2 tasks
@tay1orjones tay1orjones mentioned this pull request Jul 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakahn dakahn dakahn approved these changes

@joshblack joshblack joshblack approved these changes

@jnm2377 jnm2377 Awaiting requested review from jnm2377

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tay1orjones @joshblack @dakahn