Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(readme): fix classname typo in code example #8837

Merged
merged 2 commits into from
Jun 3, 2021
Merged

fix(readme): fix classname typo in code example #8837

merged 2 commits into from
Jun 3, 2021

Conversation

keithkade
Copy link
Contributor

Makes the classname in css code snippet match the classname jsx code snippet

Changelog

Changed

  • Fix typo in icons-react README

Testing / Reviewing

NA

@keithkade keithkade requested a review from a team as a code owner June 3, 2021 20:29
@keithkade keithkade requested review from tay1orjones and tw15egan June 3, 2021 20:29
@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2021 •
edited
Loading

DCO Assistant Lite bot All contributors have signed the DCO.

@keithkade
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

@netlify
Copy link

netlify bot commented Jun 3, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: e414683

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60b93b9938d2a70007475297

😎 Browse the preview: https://deploy-preview-8837--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jun 3, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: b03ce73

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60b93c8838d2a70007476367

😎 Browse the preview: https://deploy-preview-8837--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jun 3, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: e414683

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60b93b990b22450007eafd5b

😎 Browse the preview: https://deploy-preview-8837--carbon-components-react.netlify.app

@kodiakhq kodiakhq bot merged commit 38b8f92 into carbon-design-system:main Jun 3, 2021
@keithkade keithkade deleted the patch-1 branch June 3, 2021 21:11
@netlify
Copy link

netlify bot commented Jun 3, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: b03ce73

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60b93c88bf8afd0007c35cb6

😎 Browse the preview: https://deploy-preview-8837--carbon-components-react.netlify.app

@jnm2377 jnm2377 mentioned this pull request Jun 9, 2021
Closed
22 tasks
emyarod pushed a commit to emyarod/carbon that referenced this pull request Jun 10, 2021
@keithkade @kodiakhq @emyarod
fix(readme): fix classname typo in code example (carbon-design-system…
c22d7a2 
…#8837)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw15egan tw15egan tw15egan approved these changes

@tay1orjones tay1orjones tay1orjones approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keithkade @tay1orjones @tw15egan