Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New maintained fork #34

Open
andig opened this issue Mar 22, 2019 · 7 comments
Open

New maintained fork #34

andig opened this issue Mar 22, 2019 · 7 comments

Comments

@andig
Copy link

andig commented Mar 22, 2019

@carlos22 I wanted to point you to https://github.com/andig/carddav2fb where I've created a fork of jensmaus about 6 18 months ago. The codebase has been entirely rewritten and some features added, e.g. ability to maintain quickdial and vanity numbers or pretty-printing phone numbers.

If interested I'd be happy accept PRs and act as "official" fork.

Cheers,
Andreas

@andig andig changed the title New "officiel" fork New "official" fork Mar 22, 2019
@andig andig changed the title New "official" fork New maintained fork Mar 22, 2019
@jens-maus
Copy link
Collaborator

@andig Thanks for your hard work. However, IMHO it would be better if you would simply submit your changes as a PR for @carlos22 to be integrated rather than having yet-another fork of carddav2fb. In fact, as @carlos22 integrated my changes recently I will also close my fork anytime soon.

@andig
Copy link
Author

andig commented Mar 22, 2019

I would be happy if @carlos22 wants to look at the fork. However, it has been entirely rewritten: curl replaced by guzzle, parser replaced by library (and in-sourced again due to missing feature). Lots of grown (not to say spaghetti) code rewritten. So there won't be an easy merge and I'm not sure if it would be worth it.

I've added and closed a PR at #35 to give an impression.

Happy to wait for @carlos22 feedback and take it from there.

@carlos22
Copy link
Owner

Looks pretty good. 👍
Will test it soon.
I sure can integrate the changes (if it works well, but i assume it does) and I can give you write access to the repo if you want. The other possibility is to create an github organization for the repo.

@carlos22
Copy link
Owner

How should we proceed? I we might create a organisation and rename this repo to carddav2fb-legacy? We might add a small migration guide?

@andig
Copy link
Author

andig commented May 12, 2019

/cc @blacksenator

@carlos22
Copy link
Owner

It might be better to merge the changes and branch the current master to legacy. This way we don't loose the stars and stuff.

@andig
Copy link
Author

andig commented May 13, 2019

As for upgrade instructions we‘d need ro compare how the two have diverged. I really have no idea about this repo‘s functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants