-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New maintained fork #34
Comments
I would be happy if @carlos22 wants to look at the fork. However, it has been entirely rewritten: curl replaced by guzzle, parser replaced by library (and in-sourced again due to missing feature). Lots of grown (not to say spaghetti) code rewritten. So there won't be an easy merge and I'm not sure if it would be worth it. I've added and closed a PR at #35 to give an impression. Happy to wait for @carlos22 feedback and take it from there. |
Looks pretty good. 👍 |
How should we proceed? I we might create a organisation and rename this repo to carddav2fb-legacy? We might add a small migration guide? |
/cc @blacksenator |
It might be better to merge the changes and branch the current master to legacy. This way we don't loose the stars and stuff. |
As for upgrade instructions we‘d need ro compare how the two have diverged. I really have no idea about this repo‘s functionality. |
@carlos22 I wanted to point you to https://github.com/andig/carddav2fb where I've created a fork of jensmaus about
618 months ago. The codebase has been entirely rewritten and some features added, e.g. ability to maintain quickdial and vanity numbers or pretty-printing phone numbers.If interested I'd be happy accept PRs and act as "official" fork.
Cheers,
Andreas
The text was updated successfully, but these errors were encountered: