-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:check closed in synchronized block when multi thread. #721
Conversation
Thank you very much for your contribution! Would it at all be possible to provide some sort of test case for this? |
@carlspring Just added a test for thread safe close. I'm not sure how to make a test for multi write because it may not be stable for throwing an io exception when one thread is closing and another is writing. |
Hey @songjinze , Sorry for our delay - we've been busy at our daytime work and had to do some pipeline fixes to allow builds to run from contributors which was why we postponed merging this for so long. We are planning to merge this PR and release 1.0.2 at some point this week or the beginning of next. Don't worry about rebasing / updating your PR with the upstream. We'll do it for you before we merge. :) |
@songjinze thanks for your contribution! :) |
Pull Request Description
Should check closed when multi thread in synchronized block so that stream won't be closed twice.
Acceptance Test
gradle clean build
still works.Questions
Does this pull request break backward compatibility?
Does this pull request require other pull requests to be merged first?
Does this require an update of the documentation?