Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gradle): Merge jar task configuration in build.gradle.kts #755

Merged
merged 2 commits into from
Sep 26, 2023
Merged

chore(gradle): Merge jar task configuration in build.gradle.kts #755

merged 2 commits into from
Sep 26, 2023

Conversation

guicamest
Copy link
Contributor

Pull Request Description

This pull request merges the two configurations of the jar gradle task in build.gradle.kts.

Acceptance Test

  • Building the code with gradle clean build still works.

Questions

  • Does this pull request break backward compatibility?

  • Does this pull request require other pull requests to be merged first?

    • Yes, please see #...
    • No

  • Does this require an update of the documentation?

    • Yes, please see [provide details here]
    • No

steve-todorov
steve-todorov reviewed Sep 26, 2023
View reviewed changes
build.gradle.kts Outdated Show resolved Hide resolved
@steve-todorov steve-todorov deployed to external-collaborators September 26, 2023 10:05 — with GitHub Actions Active
@steve-todorov steve-todorov deployed to external-collaborators September 26, 2023 10:05 — with GitHub Actions Active
@steve-todorov steve-todorov deployed to external-collaborators September 26, 2023 10:05 — with GitHub Actions Active
@steve-todorov steve-todorov deployed to external-collaborators September 26, 2023 10:05 — with GitHub Actions Active
@steve-todorov steve-todorov deployed to external-collaborators September 26, 2023 10:05 — with GitHub Actions Active
@steve-todorov steve-todorov deployed to external-collaborators September 26, 2023 10:05 — with GitHub Actions Active
steve-todorov
steve-todorov approved these changes Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@steve-todorov steve-todorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution! :)

@steve-todorov steve-todorov merged commit 5b6f838 into carlspring:master Sep 26, 2023
@github-actions github-actions bot mentioned this pull request Sep 26, 2023
Merged
@guicamest guicamest deleted the merge-jar-gradle-task branch September 26, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steve-todorov steve-todorov steve-todorov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guicamest @steve-todorov