Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rewrite): Use S3Path.getBucketName #758

Merged
merged 2 commits into from
Sep 28, 2023
Merged

chore(rewrite): Use S3Path.getBucketName #758

merged 2 commits into from
Sep 28, 2023

Conversation

guicamest
Copy link
Contributor

Pull Request Description

This pull request replaces usages of S3Path.getFileStore().getName() with S3Path.getBucketName() with the goal to have a clearer intention of what is needed. The method already exists and it is delegating to fileStore.getName(), so tests are still working 🎉

Acceptance Test

  • Building the code with gradle clean build still works.

Questions

  • Does this pull request break backward compatibility?

  • Does this pull request require other pull requests to be merged first?

    • Yes, please see #...
    • No

  • Does this require an update of the documentation?

    • Yes, please see [provide details here]
    • No

@guicamest guicamest changed the title Use get bucket name chore(rewrite): Use S3Path.getBucketName Sep 27, 2023
carlspring
carlspring approved these changes Sep 27, 2023
View reviewed changes
Copy link
Owner

@carlspring carlspring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

steve-todorov
steve-todorov approved these changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@steve-todorov steve-todorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@steve-todorov steve-todorov deployed to external-collaborators September 28, 2023 15:32 — with GitHub Actions Active
@steve-todorov steve-todorov deployed to external-collaborators September 28, 2023 15:32 — with GitHub Actions Active
@steve-todorov steve-todorov deployed to external-collaborators September 28, 2023 15:32 — with GitHub Actions Active
@steve-todorov steve-todorov deployed to external-collaborators September 28, 2023 15:32 — with GitHub Actions Active
@steve-todorov steve-todorov deployed to external-collaborators September 28, 2023 15:32 — with GitHub Actions Active
@steve-todorov steve-todorov deployed to external-collaborators September 28, 2023 15:32 — with GitHub Actions Active
@steve-todorov steve-todorov added this to the 1.0.3 milestone Sep 28, 2023
@steve-todorov steve-todorov merged commit 05fb2d7 into carlspring:master Sep 28, 2023
@guicamest guicamest deleted the useGetBucketName branch September 28, 2023 16:21
@github-actions github-actions bot mentioned this pull request Sep 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steve-todorov steve-todorov steve-todorov approved these changes

@carlspring carlspring carlspring approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
1.0.3
Development

Successfully merging this pull request may close these issues.
3 participants
@guicamest @carlspring @steve-todorov