Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(S3Path): remove and get first part of the paths with one method call #759

Merged
merged 1 commit into from
Sep 28, 2023
Merged

chore(S3Path): remove and get first part of the paths with one method call #759

merged 1 commit into from
Sep 28, 2023

Conversation

guicamest
Copy link
Contributor

Pull Request Description

This pull request reduces the code in the S3Path constructor. There is a call to get the first item of the paths and after a call to remove it, but remove returns the item at that position, so it can be used to get as well.

Acceptance Test

  • Building the code with gradle clean build still works.

Questions

  • Does this pull request break backward compatibility?

  • Does this pull request require other pull requests to be merged first?

    • Yes, please see #...
    • No

  • Does this require an update of the documentation?

    • Yes, please see [provide details here]
    • No

@guicamest guicamest deployed to external-collaborators September 27, 2023 20:49 — with GitHub Actions Active
@guicamest guicamest deployed to external-collaborators September 27, 2023 20:49 — with GitHub Actions Active
@guicamest guicamest deployed to external-collaborators September 27, 2023 20:49 — with GitHub Actions Active
@guicamest guicamest deployed to external-collaborators September 27, 2023 20:49 — with GitHub Actions Active
@guicamest guicamest deployed to external-collaborators September 27, 2023 20:49 — with GitHub Actions Active
@guicamest guicamest deployed to external-collaborators September 27, 2023 20:49 — with GitHub Actions Active
@steve-todorov steve-todorov added this to the 1.0.3 milestone Sep 28, 2023
@steve-todorov steve-todorov deployed to external-collaborators September 28, 2023 16:32 — with GitHub Actions Active
@steve-todorov steve-todorov deployed to external-collaborators September 28, 2023 16:32 — with GitHub Actions Active
@steve-todorov steve-todorov deployed to external-collaborators September 28, 2023 16:32 — with GitHub Actions Active
@steve-todorov steve-todorov deployed to external-collaborators September 28, 2023 16:32 — with GitHub Actions Active
@steve-todorov steve-todorov deployed to external-collaborators September 28, 2023 16:32 — with GitHub Actions Active
@steve-todorov steve-todorov deployed to external-collaborators September 28, 2023 16:32 — with GitHub Actions Active
@steve-todorov steve-todorov merged commit 3239ec7 into carlspring:master Sep 28, 2023
@github-actions github-actions bot mentioned this pull request Sep 28, 2023
Merged
@guicamest guicamest deleted the removeAndGet branch September 28, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
1.0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@guicamest @steve-todorov