Fix Command Dispatcher CI Bug

[AdnaneKhan]

Pull Request Description

This pull request updates the command dispatcher workflow to perform a check for an actor within an Array instead of a String. String contains a substring check so that substring usernames would pass the check.

See: https://docs.github.com/en/actions/learn-github-actions/expressions#contains

Acceptance Test

N/A

Questions

• Does this pull request break backward compatibility?

  • Yes and my commit follows the Conventional Commits Specification
  • No

• Does this pull request require other pull requests to be merged first?

  • Yes, please see #...
  • No

• Does this require an update of the documentation?

  • Yes, please see [provide details here]
  • No

[steve-todorov]

Hey @AdnaneKhan,

Github Actions has a hidden "feature" (or rather bug) which we appear to be using:

      - name: Test
        if: |
          contains('["carlspring", "steve-todorov"]', 'steve-todorov')
        run: |
          echo "Runs."

      - name: Does not run
        if: |
          contains('["carlspring", "steve-todorov"]', 'test')
        run: |
          echo "Does not run."

      - name: Test
        if: |
          contains(fromJSON('["carlspring", "steve-todorov"]'), 'steve-todorov')
        run: |
          echo "Runs."

      - name: Does not run
        if: |
          contains(fromJSON('["carlspring", "steve-todorov"]'), 'test')
        run: |
          echo "Does not run."

However I believe it is better to use fromJSON() as GH might change this.
Thank you very much for pointing this out!

[AdnaneKhan]

Hey @AdnaneKhan,

Github Actions has a hidden "feature" (or rather bug) which we appear to be using:

      - name: Test
        if: |
          contains('["carlspring", "steve-todorov"]', 'steve-todorov')
        run: |
          echo "Runs."

      - name: Does not run
        if: |
          contains('["carlspring", "steve-todorov"]', 'test')
        run: |
          echo "Does not run."

      - name: Test
        if: |
          contains(fromJSON('["carlspring", "steve-todorov"]'), 'steve-todorov')
        run: |
          echo "Runs."

      - name: Does not run
        if: |
          contains(fromJSON('["carlspring", "steve-todorov"]'), 'test')
        run: |
          echo "Does not run."

However I believe it is better to use fromJSON() as GH might change this. Thank you very much for pointing this out!

Ah, if you replaced ‘test’ with ‘arlspring’, then the old one would have worked (hence the risk - someone could register a username that was a sub string to bypass). But it’s all good now!

[steve-todorov]

Ahh yeah that would have been a problem indeed. Thank again for pointing it out!