Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3Path.toString() now returns the string representation of the path instead of the URI #875

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

steve-todorov
Copy link
Collaborator

Pull Request Description

This pull request closes #872

Acceptance Test

  • Building the code with gradle clean build still works.

Questions

  • Does this pull request break backward compatibility?

  • Does this pull request require other pull requests to be merged first?

    • Yes, please see #...
    • No
  • Does this require an update of the documentation?

    • Yes, please see [provide details here]
    • No

@steve-todorov steve-todorov changed the title S3Path.toString() returns the string representation of the path instead of the URI. S3Path.toString() now returns the string representation of the path instead of the URI Jan 15, 2025
@steve-todorov

This comment was marked as outdated.

This comment was marked as outdated.

@steve-todorov
Copy link
Collaborator Author

/deploy-pr

Copy link
Contributor

Status

Snapshot was successfully deployed!
Build logs are available here

Snapshot artifact coordinates:

org.carlspring.cloud.aws:s3fs-nio:PR-875-SNAPSHOT

Maven Central Snapshot Link:

org.carlspring.cloud.aws:s3fs-nio:PR-875-SNAPSHOT

WARNING

DO NOT USE IN PRODUCTION AS IT WILL BE DELETED AFTER MERGE!
This is a temporary snapshot preview available only for convenience.

@steve-todorov steve-todorov merged commit b9cb4ba into master Jan 16, 2025
12 checks passed
@steve-todorov steve-todorov deleted the issues/872/toString branch January 16, 2025 20:45
@github-actions github-actions bot mentioned this pull request Jan 16, 2025
Copy link
Owner

@carlspring carlspring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort out S3Path.toString() behaviour
2 participants