Skip to content
This repository has been archived by the owner on Oct 17, 2023. It is now read-only.

Inflation inject should handle parameterized types #64

Open
JakeWharton opened this issue Oct 15, 2018 · 3 comments
Open

Inflation inject should handle parameterized types #64

JakeWharton opened this issue Oct 15, 2018 · 3 comments
Labels
bug PR Welcome!

Comments

@JakeWharton
Copy link
Contributor

These cannot be specified in XML so they won't match.

We should add integration tests for this.
@JakeWharton JakeWharton added this to the 1.0 milestone Oct 15, 2018
@JakeWharton
Copy link
Contributor Author

This also affects nested types.

@JakeWharton JakeWharton mentioned this issue Oct 16, 2018
Merged
@JakeWharton JakeWharton changed the title Inflation inject shouldn't use type parameters in key Inflation inject should handle parameterized types Oct 16, 2018
@JakeWharton
Copy link
Contributor Author

The key issue was fixed, but codegen for parameterized types is still broken.

@JakeWharton JakeWharton removed this from the 1.0 milestone Oct 16, 2018
@emartynov
Copy link

Jake, can you explain more issue? Doesn't mean that class with generics will have problems with code generation?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug PR Welcome!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JakeWharton @emartynov