common: Fixing mishandling of environments with unicode values #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbohren
force-pushed
the
env-unicode-fix
branch
from
0839b27 to
e2c8922
Compare
jbohren
force-pushed
the
env-unicode-fix
branch
from
e2c8922 to
3b751e6
Compare
|
I've run into a similar issue with This looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like
shlex.splitbehaves very differently on Python 2.7 and Python 3.4. This patch is an awkward solution that defines a compatibility wrapper at import time.There are so many places that unicode/string handling is different between Python2 and Python3, and it'd be great to nail them all down in a cleaner way.Fixes #338.