resultspace: Fixing environment cache checking

[jbohren]

Currently, it could blow away environment if there are no env hooks in the resultspace (fixes #350)

@mikepurvis Give this branch a shot.

[mikepurvis]

Hmm, I'm still seeing the issue with my toy example.

git clone --recursive https://github.com/mikepurvis/catkin_tools_350.git
cd catkin_tools_350
virtualenv env
env/bin/pip install git+https://github.com/catkin/catkin_tools@fix-350
. env/bin/activate
fakeroot ./run  # sadness

Results:

------------------------------------------------------------------------------
Profile:                     default
Extending:        [explicit] /home/mpurvis/catkin_tools_350/catkin_ws/install
Workspace:                   /home/mpurvis/catkin_tools_350/overlay_ws
------------------------------------------------------------------------------
Source Space:       [exists] /home/mpurvis/catkin_tools_350/overlay_ws/src
Log Space:          [exists] /home/mpurvis/catkin_tools_350/overlay_ws/logs
Build Space:        [exists] /home/mpurvis/catkin_tools_350/overlay_ws/build
Devel Space:        [exists] /home/mpurvis/catkin_tools_350/overlay_ws/devel
Install Space:      [unused] /home/mpurvis/catkin_tools_350/overlay_ws/install
DESTDIR:            [unused] None
------------------------------------------------------------------------------
Devel Space Layout:          linked
Install Space Layout:        None
------------------------------------------------------------------------------
Additional CMake Args:       None
Additional Make Args:        None
Additional catkin Make Args: None
Internal Make Job Server:    True
Cache Job Environments:      False
------------------------------------------------------------------------------
Whitelisted Packages:        None
Blacklisted Packages:        None
------------------------------------------------------------------------------
Workspace configuration appears valid.
------------------------------------------------------------------------------
ERROR: ld.so: object 'libfakeroot-sysv.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
ERROR: ld.so: object 'libfakeroot-sysv.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
[build] Found '1' packages in 0.0 seconds.
ERROR: ld.so: object 'libfakeroot-sysv.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
ERROR: ld.so: object 'libfakeroot-sysv.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
[build] Package table is up to date.
Warning: generated devel space setup files have been deleted.
ERROR: ld.so: object 'libfakeroot-sysv.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
ERROR: ld.so: object 'libfakeroot-sysv.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
Starting  >>> catkin_tools_prebuild
No handlers could be found for logger "trollius"
ERROR: ld.so: object 'libfakeroot-sysv.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
ERROR: ld.so: object 'libfakeroot-sysv.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
ERROR: ld.so: object 'libfakeroot-sysv.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
ERROR: ld.so: object 'libfakeroot-sysv.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
ERROR: ld.so: object 'libfakeroot-sysv.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.

[jbohren]

@mikepurvis Ok, it should work now, see the last two commits for more detail. I still want to track down why this worked on 0.3.1 and not 0.4.0.

[jbohren]

I still want to track down why this worked on 0.3.1 and not 0.4.0.

Ok, the regression was introduced here: 6b8f9d6#diff-ef773b0a1c77b266490fec7730c173b4

[mikepurvis]

Looks good now.

[jbohren]

@wjwwood This should be good to merge, it makes the environment caching more robust and returns the base-environment behavior to how it works on 0.3.1.

[wjwwood]

lgtm