-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No setup.bash #87
Comments
I just realized that the workspace had actually just 1 non-catkin package and NO catkin packages in it. A while back I removed the catkin package because of dependency issues and I had forgotten. As a result, the workspace did not behave correctly when I rebuilt everything today. I think we might want to put an error/warning if this happens, because it squandered a day for me. |
I don't know why this is happening off-hand, I guess non-catkin packages may not have Either way this is probably a bug, you should be able to build a single package (regardless of the build type) in a workspace correctly.
I think the correct solution is not make sure it doesn't happen.
Surely you are being hyperbolic... |
Yeah, as far as I understand it after patching that race condition is that the setup.* files are generated by the Catkin CMake code, which doesn't get run if you don't have a catkin package in your workspace. I suggest that we run CMake in executable mode from |
That might work, but I'm not 100% sure that will work, because those functions may require things not provided by a non-catkin package. If it doesn't work we will just have to build a generic |
It was a combination of this particular bug and other catkin issues that did take an entire day to fix. When I moved the catkin packages in said workspace into another workspace, due to a dependency change, I never rebuilt everything (delete devel and build) and so I had some really weird ghost linking issues and runtime crashes that I thought were caused by bugs in my code. |
I've noticed the same problem, since I use |
I believe you could just use an empty catkin package, e.g. |
Note that cloning catkin into the workspace |
ah good point |
@scpeters @davetcoleman As an aside, my "linked-devel" prototype that supports cleaning individual packages will automatically generate setup files in the devel / install space even if you don't have a catkin package in your workspace. |
@jbohren thanks for the heads-up; that sounds like a nice set of new features that would resolve this issue. I'll keep my eye on it. |
I'm setting up a new workspace and just re-ran into this problem, I'm going to re-open atleast until #196 is merged in |
Don't forget the workaround of cloning catkin into the workspace src folder. |
I have a workspace that has 1 catkin package and 1 non-catkin package (OMPL). After building the workspace (catkin build) it only has as setup.sh file, not a setup.bash file. Why is this? Is something wrong? All my other workspaces have a setup.bash file which is what Im used to sourcing on Ubuntu 12.04.
The text was updated successfully, but these errors were encountered: