Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readability issues #3

Open
EmiMidnight opened this issue May 30, 2023 · 3 comments
Open

Readability issues #3

EmiMidnight opened this issue May 30, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@EmiMidnight
Copy link

Hey there,
theme looks very cozy but there's at least two spots that are pretty bad contrast wise currently.

Lines with active breakpoints are completely unreadable on all 4 color variants:
image

Clicking on a highlighted line/variable in the structure view is not completely unreadable, but still bad contrast wise I think:
image

Otherwise, everything else looks great over here. :)

@naldrv
Copy link
Contributor

naldrv commented May 30, 2023

Agreed. Breakpoints should probably use color-red with some added transparency.

Here are the properties that would require changing:

qproperty-line-bg-bpt-enabled: ${color-teal}; /* switch to color-red and add transparency */

/* i am unsure what these properties would look like, maybe add transparency to them as well? */
qproperty-line-bg-bpt-disabled: ${color-text};
qproperty-line-bg-bpt-unavailable: ${color-overlay0};

The variable highlight is causing readability issues because it's actually layering it's transparency with the current-line highlight. Would probably be better to switch to using a different color entirely for variable highlights. I'll put a PR together for this.

@naldrv
Copy link
Contributor

naldrv commented May 30, 2023

I added more transparency to the cursor line background color and switched the highlight background color to maroon, as well as adding more transparency.

I also think this looks much better for breakpoints (red with 30% transparency):

@EmiMidnight
Copy link
Author

Looks great! 🙏

I noticed one more issue, in the type declaration editor, the offset is invisible.
image

I added

TextEdit QWidget {
    background-color: transparent;
} 

and that seems to have fixed it.
Not sure if that causes any other changes I didn't notice.

@ValentinTT ValentinTT added the enhancement New feature or request label Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants