Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slack notification in api repo (maybe others) #482

Open
sastels opened this issue Dec 13, 2024 · 0 comments
Open

Fix slack notification in api repo (maybe others) #482

sastels opened this issue Dec 13, 2024 · 0 comments
Labels
Bug | Bogue Bug related task.

Comments

@sastels
Copy link

sastels commented Dec 13, 2024

Describe the bug

I think the curl used by GitHub actions changed. When the api CI tests fail we don't get the Slack notification anymore, and in the logs we see

{"detail":[{"type":"json_invalid","loc":["body",1],"msg":"JSON decode error","input":{},"ctx":{"error":"Expecting property name enclosed in double quotes"}}]}

(SEV-1 Critical, SEV-2 Major, SEV-3 Minor, SEV-4 Low)

To Reproduce

Steps to reproduce the behavior:

  1. Make the Slack webhook fire
  2. No notification in Slack

Expected behavior

We get a notification

Impact

We don't know when deploys fail. This could also affect manifest repo where releases could fail without us knowing.

QA

Make the webhook fire (say just in a PR)

@sastels sastels added the Bug | Bogue Bug related task. label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug | Bogue Bug related task.
Projects
None yet
Development

No branches or pull requests

1 participant