Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tailwind to 3.x #1153

Open
amazingphilippe opened this issue Apr 4, 2023 · 6 comments
Open

Upgrade tailwind to 3.x #1153

amazingphilippe opened this issue Apr 4, 2023 · 6 comments
Assignees
Labels
Dev Task for implementation of a technical solution High Priority | Haute priorité Tech Debt An issue targeting an identified technical debt UX Design and prototyping

Comments

@amazingphilippe
Copy link
Collaborator

We could make the best use of tailwind if we upgrade it. As new CSS features are adopted by browsers, older versions of tailwind won't support them.

Newer versions of tailwind also add a ton of useful features to help us build stuff.

They have upgrade guides that we can use

  1. From 1 to 2: https://v2.tailwindcss.com/docs/upgrading-to-v2
  2. From 2 to 3: https://tailwindcss.com/docs/upgrade-guide

We could also take the opportunity to clean up our config and really think about some legacy gov.uk code like:

  1. The base font size of 10px (instead of 16px)
  2. The typographic scale
  3. Breakpoints
  4. Colours, like focus colour
@amazingphilippe amazingphilippe added the Tech Debt An issue targeting an identified technical debt label Apr 4, 2023
@yaelberger-commits
Copy link
Collaborator

Test on admin with a PR and see what happens, a Bug Bash, see what breaks and some cleanup

@yaelberger-commits
Copy link
Collaborator

@yaelberger-commits yaelberger-commits added UX Design and prototyping Dev Task for implementation of a technical solution labels May 23, 2024
@andrewleith
Copy link
Member

Related PR: cds-snc/notification-admin#1821

@amazingphilippe
Copy link
Collaborator Author

amazingphilippe commented Oct 8, 2024

Included tailwind 3 upgrade as part of cds-snc/notification-admin#1821. Ready for review

@YedidaZalik
Copy link

Phil was cleaning up work on main navigation yesterday and trying to fix
PR linked at bottom for someone to check

@andrewleith
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev Task for implementation of a technical solution High Priority | Haute priorité Tech Debt An issue targeting an identified technical debt UX Design and prototyping
Projects
None yet
Development

No branches or pull requests

4 participants