Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template formatting use of special characters. Infos and relationships #1456

Closed
amazingphilippe opened this issue Jan 3, 2024 · 6 comments · Fixed by cds-snc/notification-admin#1801

Comments

@amazingphilippe
Copy link
Collaborator

amazingphilippe commented Jan 3, 2024

Description of issue

Special characters are used to allow users to format notifications and define variables in templates. These characters may not be reliably communicated by screen readers.

Screen readers don’t always communicate special characters such as punctuation. Whether characters are read out or not depends on the screen reader, verbosity settings, and whether the character appears on its own or in context. This may make variables and certain kinds of formatting challenging to use for screen reader users. For example, both parentheses used to indicate variables, and underscores used to indicate section breaks and italics are not consistently communicated by screen readers. For a detailed breakdown of screen reader support for special characters, see How screen readers read special characters: an update.

Potential fix

  • A rich text editor could help users navigate the content of a template without special characters. It might not fix everything, especially with variable parenthesis.
  • Is there a way to mark and announce variables? Would this be confusing?

Resources

@amazingphilippe
Copy link
Collaborator Author

I recommend bringing this one up with OCADU to get more ideas on how this can be fixed.

@amazingphilippe
Copy link
Collaborator Author

Notes from OCADU follow-up:

Template variables: how to tag words. Nothing really reliable in terms of basic html tags.

  1. Really on characters usually read aloud
  2. Pseudo content in CSS before placeholder variables. Careful with i18n. Would only work while previewing templates (not while editing)

@YedidaZalik
Copy link

A few details to look at
@YedidaZalik to look at it and can also sync with Phil
Phil added text for screen readers to identify variables - question about "custom content"
We need to merge it in - not a blocker

@YedidaZalik
Copy link

Yedida looked and agreed it should wait to reconsider vocab

@YedidaZalik
Copy link

Need to be merged now that have been reviewed

@foudamo
Copy link

foudamo commented Apr 18, 2024

Waiting for Andrew to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants