From 6cb98ec81e8fd62978ad01744fdbe20d62776aa3 Mon Sep 17 00:00:00 2001 From: amaitland Date: Tue, 23 Jan 2018 09:25:20 +1000 Subject: [PATCH] Nupkg Restructure Resolves #2156 Nuget packages updated to use ItemGroup None instead of Copy target Nuget props restructure to support Win32 target x86 and Win32 targets are exactly the same in content, they differ in name only, so switched to using an block Remove AnyCpu option from props files and consolidate with x86 and Win32. Set Private to false and rely on the entires to copy the files to the output folder Ideally would move the OffScreen, WinForms and WPF targets file content to the props (as they're actually props now), unfortunately we need guaranteed ordering and Nuget 2.8.x doesn't provide that, if we leave them as .targets it'll happen late enough to make sure the cef.redist list of files is provided. https://github.com/NuGet/Home/issues/4229#issuecomment-271387190 --- NuGet/CefSharp.Common.props | 21 +++------- NuGet/CefSharp.Common.targets | 69 +++++++++++++++++++------------- NuGet/CefSharp.OffScreen.props | 15 ++----- NuGet/CefSharp.OffScreen.targets | 48 +++++++++++++++++----- NuGet/CefSharp.WinForms.props | 15 ++----- NuGet/CefSharp.WinForms.targets | 46 +++++++++++++++++---- NuGet/CefSharp.Wpf.props | 15 ++----- NuGet/CefSharp.Wpf.targets | 46 +++++++++++++++++---- 8 files changed, 174 insertions(+), 101 deletions(-) diff --git a/NuGet/CefSharp.Common.props b/NuGet/CefSharp.Common.props index 4109cd200b..59ebd23b70 100644 --- a/NuGet/CefSharp.Common.props +++ b/NuGet/CefSharp.Common.props @@ -1,31 +1,20 @@ - - - - $(MSBuildThisFileDirectory)..\CefSharp\x86\CefSharp.dll - True - - - $(MSBuildThisFileDirectory)..\CefSharp\x86\CefSharp.Core.dll - True - - - $(MSBuildThisFileDirectory)..\CefSharp\x64\CefSharp.dll - True + False $(MSBuildThisFileDirectory)..\CefSharp\x64\CefSharp.Core.dll - True + False - + + $(MSBuildThisFileDirectory)..\CefSharp\x86\CefSharp.dll @@ -36,6 +25,6 @@ False - + diff --git a/NuGet/CefSharp.Common.targets b/NuGet/CefSharp.Common.targets index a74f37424d..ec72e26de3 100644 --- a/NuGet/CefSharp.Common.targets +++ b/NuGet/CefSharp.Common.targets @@ -11,38 +11,53 @@ + - $(TargetDir) + - - - - - - - - - - - - - - - - - - - + + + + + $(CefSharpTargetDir)\%(RecursiveDir)%(FileName)%(Extension) + PreserveNewest + + + $(CefSharpTargetDir)\%(RecursiveDir)%(FileName)%(Extension) + PreserveNewest + + - - + + + $(CefSharpTargetDir)\%(RecursiveDir)%(FileName)%(Extension) + PreserveNewest + + + $(CefSharpTargetDir)\%(RecursiveDir)%(FileName)%(Extension) + PreserveNewest + + - - - - - + + + $(CefSharpTargetDir)\x86\%(RecursiveDir)%(FileName)%(Extension) + PreserveNewest + + + $(CefSharpTargetDir)\x64\%(RecursiveDir)%(FileName)%(Extension) + PreserveNewest + + + $(CefSharpTargetDir)\%(RecursiveDir)%(FileName)%(Extension) + PreserveNewest + + diff --git a/NuGet/CefSharp.OffScreen.props b/NuGet/CefSharp.OffScreen.props index c2c511f902..f832972a2f 100644 --- a/NuGet/CefSharp.OffScreen.props +++ b/NuGet/CefSharp.OffScreen.props @@ -1,29 +1,22 @@ - - - - $(MSBuildThisFileDirectory)..\CefSharp\x86\CefSharp.OffScreen.dll - True - - - $(MSBuildThisFileDirectory)..\CefSharp\x64\CefSharp.OffScreen.dll - True + False - + + $(MSBuildThisFileDirectory)..\CefSharp\x86\CefSharp.OffScreen.dll False - + diff --git a/NuGet/CefSharp.OffScreen.targets b/NuGet/CefSharp.OffScreen.targets index bb9b276ad8..9a726da2af 100644 --- a/NuGet/CefSharp.OffScreen.targets +++ b/NuGet/CefSharp.OffScreen.targets @@ -1,18 +1,48 @@ - $(TargetDir) + - - + + + + - - - - - - + + + + + + + + $(CefSharpTargetDir)\%(RecursiveDir)%(FileName)%(Extension) + PreserveNewest + + + + + + + $(CefSharpTargetDir)\%(RecursiveDir)%(FileName)%(Extension) + PreserveNewest + + + + + + + + $(CefSharpTargetDir)\%(RecursiveDir)%(FileName)%(Extension) + PreserveNewest + + + + diff --git a/NuGet/CefSharp.WinForms.props b/NuGet/CefSharp.WinForms.props index c048375805..bb3a356a1b 100644 --- a/NuGet/CefSharp.WinForms.props +++ b/NuGet/CefSharp.WinForms.props @@ -1,29 +1,22 @@ - - - - $(MSBuildThisFileDirectory)..\CefSharp\x86\CefSharp.WinForms.dll - True - - - $(MSBuildThisFileDirectory)..\CefSharp\x64\CefSharp.WinForms.dll - True + False - + + $(MSBuildThisFileDirectory)..\CefSharp\x86\CefSharp.WinForms.dll False - + diff --git a/NuGet/CefSharp.WinForms.targets b/NuGet/CefSharp.WinForms.targets index 5a5c2dbca5..82b8a44634 100644 --- a/NuGet/CefSharp.WinForms.targets +++ b/NuGet/CefSharp.WinForms.targets @@ -1,18 +1,48 @@ - $(TargetDir) + + + - - - - - - - + + + + + + + + + $(CefSharpTargetDir)\%(RecursiveDir)%(FileName)%(Extension) + PreserveNewest + + + + + + + $(CefSharpTargetDir)\%(RecursiveDir)%(FileName)%(Extension) + PreserveNewest + + + + + + + + $(CefSharpTargetDir)\%(RecursiveDir)%(FileName)%(Extension) + PreserveNewest + + + + diff --git a/NuGet/CefSharp.Wpf.props b/NuGet/CefSharp.Wpf.props index 8755e8cc3a..ec81383ea5 100644 --- a/NuGet/CefSharp.Wpf.props +++ b/NuGet/CefSharp.Wpf.props @@ -1,29 +1,22 @@ - - - - $(MSBuildThisFileDirectory)..\CefSharp\x86\CefSharp.Wpf.dll - True - - - $(MSBuildThisFileDirectory)..\CefSharp\x64\CefSharp.Wpf.dll - True + False - + + $(MSBuildThisFileDirectory)..\CefSharp\x86\CefSharp.Wpf.dll False - + diff --git a/NuGet/CefSharp.Wpf.targets b/NuGet/CefSharp.Wpf.targets index f070921e4a..f1033f1a3a 100644 --- a/NuGet/CefSharp.Wpf.targets +++ b/NuGet/CefSharp.Wpf.targets @@ -1,18 +1,48 @@ - $(TargetDir) + + + - - - - - - - + + + + + + + + + $(CefSharpTargetDir)\%(RecursiveDir)%(FileName)%(Extension) + PreserveNewest + + + + + + + $(CefSharpTargetDir)\%(RecursiveDir)%(FileName)%(Extension) + PreserveNewest + + + + + + + + $(CefSharpTargetDir)\%(RecursiveDir)%(FileName)%(Extension) + PreserveNewest + + + +