Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove WebBrowserExtensions.LoadUrlWithPostData #2705

Closed
1 of 3 tasks
amaitland opened this issue Mar 26, 2019 · 7 comments
Closed
1 of 3 tasks

Remove WebBrowserExtensions.LoadUrlWithPostData #2705

amaitland opened this issue Mar 26, 2019 · 7 comments
Labels
breaking-change

Comments

@amaitland
Copy link
Member

amaitland commented Mar 26, 2019 •
edited
Loading

The underlying LoadRequest method has become unreliable. It no longer sends Cookie with requests. You can also only call it after the browser has successfully loaded a Url.

LoadRequest bypasses the normal navigation pipeline

https://magpcss.org/ceforum/viewtopic.php?f=6&t=16592&p=41067#p41074

As a result we'll remove WebBrowserExtensions.LoadUrlWithPostData

  • Mark WebBrowserExtensions.LoadUrlWithPostData as Obsolete
  • Remove WebBrowserExtensions.LoadUrlWithPostData
  • Add additional xml doc to LoadRequest making it clear it's not reliable.
@amaitland amaitland added this to the 75.0.0 milestone Mar 26, 2019
@amaitland
Copy link
Member Author

The only reliable method is to use OnBeforeResourceLoad, you can append Post Data through this method.

amaitland added a commit that referenced this issue Mar 26, 2019
@amaitland
WebBrowserExtensions.LoadUrlWithPostData - Mark as Obsolete
ba008ee 
Issue #2705
@amaitland amaitland mentioned this issue Mar 26, 2019
Closed
@amaitland
Copy link
Member Author

It maybe possible to still send cookies see https://magpcss.org/ceforum/viewtopic.php?f=6&t=16650#p41343

amaitland added a commit that referenced this issue Apr 10, 2019
@amaitland
WebBrowserExtensions.LoadUrlWithPostData - Set UrlRequestFlags.AllowC…
525a4f1 
…achedCredentials

Possible workaround for sending cookies

Issue #2705
amaitland added a commit that referenced this issue Apr 10, 2019
@amaitland
WebBrowserExtensions.LoadUrlWithPostData - Set UrlRequestFlags.AllowC…
ad7cbcc 
…achedCredentials

Possible workaround for sending cookies

Issue #2705
@amaitland
Copy link
Member Author

If set user name, password, and cookies may be sent with the request, and cookies may be saved from the response.

Setting UrlRequestFlags.AllowCachedCredentials is reported to send cookies, which makes sense based on the flag comment.

Changes made to master and cefsharp/73 branch. If this provides to be successful then we'll remove the Obsolete attribute and keep the method.

@cefsharp cefsharp deleted a comment from soul-soft Jun 9, 2019
@amaitland amaitland removed this from the 75.0.0 milestone Jul 7, 2019
@amaitland
Copy link
Member Author

Will defer this change until we see the impact of the new Network Service (#2743)

@amaitland
Copy link
Member Author

No further reports of problems, will leave the code as is for now.

@ajcoll5
Copy link

ajcoll5 commented May 5, 2020

No further reports of problems, will leave the code as is for now.

The method is still marked as obsolete with a message stating it will be removed in version 75. Since this issue is closed and the method is being kept, should this message be removed?

@amaitland
Copy link
Member Author

You are welcome to submit a pull request.

amaitland added a commit that referenced this issue May 1, 2021
@amaitland
Core - WebBrowserExtensions.LoadUrlWithPostData remove Obsolete attri…
744ff3f 
…bute

No further reports of issues

#2705
amaitland added a commit that referenced this issue May 1, 2021
@amaitland
Core - WebBrowserExtensions.LoadUrlWithPostData remove Obsolete attri…
6efde81 
…bute

No further reports of issues

#2705
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amaitland @ajcoll5