-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IME implementation in WPF #2749
Conversation
Please remove unnessicary unrelated code changes. There are quite a few at first glance. What versions of Windows have you tested on? |
Which are the unrelated code changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments inline, please review and fix.
@a-marmer View your proposed changes using the Files Changed tab above, aka https://github.com/cefsharp/CefSharp/pull/2749/files |
Has this been tested on HighDPI displays? Initially will need to split this out into it's own keyboard handler so it's optional. If that's sorted in the next day or two it can be inclu7in the 73 release for people to test. Personally IME is not something I'm familiar with, nor do I have a requirement for using it. |
❌ Build CefSharp 74.1.130-CI3081 failed (commit dca5e407fb by @a-marmer) |
❌ Build CefSharp 74.1.130-CI3089 failed (commit 5f38407b79 by @a-marmer) |
❌ Build CefSharp 74.1.130-CI3090 failed (commit 4e59475642 by @a-marmer) |
❌ Build CefSharp 74.1.130-CI3091 failed (commit 1c374486bb by @a-marmer) |
It was tested with HighDPI and it works.. Though if DPI is changed when application is running, CefSharp3.sln builds on my machine, it is not clear why build fails with appveyor, do you know why? |
❌ Build CefSharp 74.1.130-CI3092 failed (commit c84e0d7b62 by @a-marmer) |
Inline functions are not supported by the default compiler used with |
✅ Build CefSharp 74.1.130-CI3093 completed (commit 4675ac29b0 by @a-marmer) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of issues remain unresolved, new ones added.
✅ Build CefSharp 74.1.130-CI3097 completed (commit d8e3c4e759 by @a-marmer) |
I've taken your I've restructured things in 6ed722a you can review and comment here. I haven't had time to test anything. Code is now self contained, it's in the |
IME implementation in WPF which supports Japanese, Chinese, Korean languages.
Instruction how to test install it on Windows 10 https://www.coscom.co.jp/learnjapanese801/msime_win10_en1.html