WPF - Add IME Support #2757
Merged
WPF - Add IME Support #2757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Restructure ImeHandler to be a static class as it really didn't maintain any state, now hwnd is passed in as param - Renamed many of the methods to Ime for consistency (IME in all caps doesn't patch the naming convention used) - The WpfIMEKeyboardHandler implementation is pretty much self contained now, only a single reference in ChromiumWebBrowser also moved into Experimental folder/namespace
kkwpsv
pushed a commit
to kkwpsv/CefSharp
that referenced
this pull request
Dec 27, 2019
* WPF - Add initial IME implementation * WPF - WpfImeKeyboardHandler handler code cleanup - Restructure ImeHandler to be a static class as it really didn't maintain any state, now hwnd is passed in as param - Renamed many of the methods to Ime for consistency (IME in all caps doesn't patch the naming convention used) - The WpfIMEKeyboardHandler implementation is pretty much self contained now, only a single reference in ChromiumWebBrowser also moved into Experimental folder/namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #2749
The
WpfImeKeyboardHandlerhandler contains all the relevantIMErelated code. It's in theCefSharp.Wpf.Experimentalnamespace for now.