-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CEF/Chromium NetworkService API Changes #2809
CEF/Chromium NetworkService API Changes #2809
Conversation
✅ Build CefSharp 74.1.130-CI3143 completed (commit af5126fceb by @amaitland) |
d989108
to
c2016da
Compare
✅ Build CefSharp 74.1.130-CI3144 completed (commit 4b68a40f59 by @amaitland) |
c2016da
to
a83932c
Compare
❌ Build CefSharp 74.1.130-CI3145 failed (commit 405222fee2 by @amaitland) |
Compiles, that's about it at this point, there are major CEF breaking changes, and lots to be addressed. Browser Process (main process) - Removed IResourceHandlerFactory as it no longer fits with the structure that CEF provides - New IResourceRequestHandler interface added, not plumbed in yet - CefSettings - Add RootCachePath and ApplicationClientIdForFileScanning BrowserSubprocess (render process) - SendProcessMessage was moved from CefBrowser to CefFrame - OnBrowserCreated added extraInfo param The BrowserSubprocess changes for this upgrade should be complete
a83932c
to
a73e56d
Compare
✅ Build CefSharp 74.1.130-CI3146 completed (commit 05f2adaab1 by @amaitland) |
✅ Build CefSharp 75.0.30-CI3147 completed (commit 6b00d55247 by @amaitland) |
Can be overridden
✅ Build CefSharp 75.0.30-CI3148 completed (commit 01dea3fd07 by @amaitland) |
Not complete or tested yet
becb14d
to
6dde636
Compare
✅ Build CefSharp 75.0.30-CI3149 completed (commit 7b5e137162 by @amaitland) |
Clarifications about empty/non-empty values for CachePath/RootCachePath
✅ Build CefSharp 75.0.30-CI3150 completed (commit 32d65a07f0 by @amaitland) |
…custom scheme is broken currently. Reported upstream at https://bitbucket.org/chromiumembedded/cef/issues/2685/networkservice-custom-scheme-unable-to
✅ Build CefSharp 75.0.30-CI3151 completed (commit 927bcda2f6 by @amaitland) |
…wser Previously objects were sent in OnRenderViewReady, which is only called once for a browser instance, not for process switches Now objects are passed when the browser is created, still need to check for popup handling
…t objects) GetObjects was returning all objects, even those that are sub objects
✅ Build CefSharp 75.0.30-CI3152 completed (commit bf5e22ab85 by @amaitland) |
This reverts commit 9d47c2e.
✅ Build CefSharp 75.0.30-CI3159 completed (commit 939ac97c2b by @amaitland) |
✅ Build CefSharp 75.0.30-CI3160 completed (commit e2a5d0f021 by @amaitland) |
✅ Build CefSharp 75.0.30-CI3161 completed (commit 86ab162efc by @amaitland) |
Now uses IResourceHandler.Open to call IResourceHandler.ProcessRequestAsync IResourceHandler.ProcessRequestAsync now returns CefReturnValue instead of bool as there are three states
1bcdc81
to
861f463
Compare
✅ Build CefSharp 75.0.30-CI3162 completed (commit acbeec6fd3 by @amaitland) |
✅ Build CefSharp 75.0.110-CI3163 completed (commit 0b81114525 by @amaitland) |
✅ Build CefSharp 75.0.110-CI3164 completed (commit a296924a5f by @amaitland) |
✅ Build CefSharp 75.0.110-CI3165 completed (commit 90dce1ddf9 by @amaitland) |
…to GetResourceRequestHandler
…to override only the methods they require
Also renamed CefSharp.Example.Handlers.RequestHandler to CefSharp.Example.Handlers.ExampleRequestHandler Will Add in Obsolete DefaultRequestHandler
…ility Ditching Default from naming convention.
- Make members protected virtual (BREAKING CHANGE) - Remove Default from name of DefaultResourceRequestHandlerFactory/DefaultResourceRequestHandlerFactoryItem
✅ Build CefSharp 75.0.110-CI3168 completed (commit 3dc37617da by @amaitland) |
✅ Build CefSharp 75.0.110-CI3171 completed (commit 616012d6ff by @amaitland) |
- Remove commented out code - Remove event args for methods that now don't exist in RequestHandler - Basic code cleanup.
✅ Build CefSharp 75.0.110-CI3172 completed (commit 7ca2a34b37 by @amaitland) |
Upgrade to CEF 75.0.11+gf50b3c2+chromium-75.0.3770.100
CefResourceRequestHandlerAdapter
Add checks for null frame/browserResolves #2743 (The details of the API changes will be outlined there)