Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CEF/Chromium NetworkService API Changes #2809

Merged
merged 35 commits into from
Jun 25, 2019

Conversation

amaitland
Copy link
Member

@amaitland amaitland commented Jun 12, 2019

Upgrade to CEF 75.0.11+gf50b3c2+chromium-75.0.3770.100

  • Revise ResourceHandler (some methods have been deprecated)
  • Implement ICookieAccessFilter wrapper
  • CefResourceRequestHandlerAdapter Add checks for null frame/browser
  • New methods added to CefRequest and CefResponse.
  • Add SSL_CONNECTION_VERSION_TLS1_3 = 6
  • Update build version number again

Resolves #2743 (The details of the API changes will be outlined there)

@amaitland amaitland added this to the 75.0.0 milestone Jun 12, 2019
@AppVeyorBot
Copy link

@amaitland amaitland force-pushed the refactor/networkservice branch from d989108 to c2016da Compare June 12, 2019 10:51
@AppVeyorBot
Copy link

@amaitland amaitland force-pushed the refactor/networkservice branch from c2016da to a83932c Compare June 12, 2019 10:54
@AppVeyorBot
Copy link

Compiles, that's about it at this point, there are major CEF breaking changes, and lots to be addressed.

Browser Process (main process)
- Removed IResourceHandlerFactory as it no longer fits with the structure that CEF provides
- New IResourceRequestHandler interface added, not plumbed in yet
- CefSettings - Add RootCachePath and ApplicationClientIdForFileScanning

BrowserSubprocess (render process)
- SendProcessMessage was moved from CefBrowser to CefFrame
- OnBrowserCreated added extraInfo param

The BrowserSubprocess changes for this upgrade should be complete
@amaitland amaitland force-pushed the refactor/networkservice branch from a83932c to a73e56d Compare June 12, 2019 11:57
@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@amaitland amaitland force-pushed the refactor/networkservice branch from becb14d to 6dde636 Compare June 13, 2019 22:20
@AppVeyorBot
Copy link

Clarifications about empty/non-empty values for CachePath/RootCachePath
@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

…wser

Previously objects were sent in OnRenderViewReady, which is only called once for a browser instance, not for process switches
Now objects are passed when the browser is created, still need to check for popup handling
…t objects)

GetObjects was returning all objects, even those that are sub objects
@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

Now uses IResourceHandler.Open to call IResourceHandler.ProcessRequestAsync
IResourceHandler.ProcessRequestAsync now returns CefReturnValue instead of bool as there are three states
@amaitland amaitland force-pushed the refactor/networkservice branch from 1bcdc81 to 861f463 Compare June 21, 2019 04:53
@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

Also renamed CefSharp.Example.Handlers.RequestHandler to CefSharp.Example.Handlers.ExampleRequestHandler

Will Add in Obsolete DefaultRequestHandler
…ility

Ditching Default from naming convention.
- Make members protected virtual (BREAKING CHANGE)
- Remove Default from name of DefaultResourceRequestHandlerFactory/DefaultResourceRequestHandlerFactoryItem
@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

- Remove commented out code
- Remove event args for methods that now don't exist in RequestHandler
- Basic code cleanup.
@AppVeyorBot
Copy link

@amaitland amaitland changed the title WIP - CEF/Chromium NetworkService API Changes CEF/Chromium NetworkService API Changes Jun 25, 2019
@amaitland amaitland marked this pull request as ready for review June 25, 2019 09:24
@amaitland amaitland merged commit aa238b2 into cefsharp:master Jun 25, 2019
@amaitland amaitland mentioned this pull request Jul 28, 2019
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chromium NetworkService API Changes
2 participants