WinForms - Add Shift+Tab to IsInputKey (used when MultiThreadedMessageLoop is disabled)

[eklavyamirani]

Summary:

• When MultiThreaded message loop is disabled, we use the winform message loop. We want to ensure that Shift+Tab (cycle selection back) is recognized as a valid input by the browser control otherwise it breaks keyboard accessibility.

Changes:

• I have added Shift + Tab to the list of inputs recognized by the browser.

How Has This Been Tested?

I changed the winforms example and set MultiThreadedMessageLoop = false. Then I opened the webpage and tried shift + tab. The selection didn't cycle through the HTML content, instead it cycled through the WinForm controls.
Then, I added my change and redid the same steps as above. Shift + tab works fine.

Note: I was looking at the original change to the code that I am modifying but couldn't find any automated tests that were written for it. I'd be happy to write tests if someone can point me to the right direction.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Updated documentation

Checklist:

• Tested the code(if applicable)
• Commented my code
• Changed the documentation(if applicable)
• New files have a license disclaimer
• The formatting is consistent with the project (project supports .editorconfig)

[AppVeyorBot]

✅ Build CefSharp 74.1.130-CI3157 completed (commit 9d897db854 by @)

[amaitland]

Thanks, looks fine. Will merge after I've had a chance to test.

Don't worry about providing a screenshot.

[eklavyamirani]

Perfect. Thanks. I’d be happy to help write tests for the code here. Are there any E2E tests that I can add it to? Thanks, Eklavya

…

________________________________ From: Alex Maitland <[email protected]> Sent: Wednesday, June 19, 2019 3:30:52 PM To: cefsharp/CefSharp Cc: Eklavya; Author Subject: Re: [cefsharp/CefSharp] Add Shift+Tab as inputs to browser when MultiThreadedMessageLoop is disabled (#2814) Thanks, looks fine. Will merge after I've had a chance to test. Don't worry about providing a screenshot. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#2814?email_source=notifications&email_token=AAKB5AJGU26D2XUQEX4KDPLP3KXRZA5CNFSM4HZNY7SKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYDO2TI#issuecomment-503770445>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAKB5AN4Q7O5QWP5HIIGYVLP3KXRZANCNFSM4HZNY7SA>.

[amaitland]

Are there any E2E tests that I can add it to?

Currently no, the plan is to write some tests with WinAppDriver, contributions in this area would be welcome.