Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.0-rc13 not working with Ledger on Ubuntu #2412

Closed
4 tasks
adlerjohn opened this issue Sep 3, 2023 · 5 comments
Closed
4 tasks

1.0.0-rc13 not working with Ledger on Ubuntu #2412

adlerjohn opened this issue Sep 3, 2023 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@adlerjohn
Copy link
Member

Summary of Bug

$ ./build/celestia-appd version
1.0.0-rc13
$ ./build/celestia-appd keys add john-key --ledger
Error: failed to generate ledger key: failed to retrieve device: ledger nano S: support for ledger devices is not available in this executable

Version

v1.0.0-rc13

Steps to Reproduce

make build on Ubuntu 20.04, then above.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adlerjohn adlerjohn added the bug Something isn't working label Sep 3, 2023
@liamsi
Copy link
Member

liamsi commented Sep 3, 2023

This is really weird as this was fixed here: #2014

@liamsi
Copy link
Member

liamsi commented Sep 3, 2023

Looks like the above made into main but never was included in a release candidate.

@adlerjohn
Copy link
Member Author

#2014 was merged into main, and not ported to the v1.x branch. This is why I was hesitant to have a forward-looking-release branch instead of cutting releases off main.

@adlerjohn
Copy link
Member Author

We'll need a new rc with #2014 included cc @evan-forbes

@evan-forbes evan-forbes self-assigned this Sep 4, 2023
@evan-forbes evan-forbes added this to the Mainnet milestone Sep 4, 2023
@evan-forbes
Copy link
Member

can close with #2415

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants