Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't store min+max namespace IDs in badger inverted index keys #2617

Open
musalbas opened this issue Aug 27, 2023 · 2 comments
Open

Don't store min+max namespace IDs in badger inverted index keys #2617

musalbas opened this issue Aug 27, 2023 · 2 comments
Labels
external Issues created by non node team members needs:triage pending:close

Comments

@musalbas
Copy link
Member

This should save around 50% of the storage used by the inverted index. We don't need to put min+max namespace IDs in the inverted index, as they don't contribute to collision resistance. To access a key, you can simply truncate the namespace ID.

@github-actions github-actions bot added needs:triage external Issues created by non node team members labels Aug 27, 2023
@moldis
Copy link
Contributor

moldis commented Jan 14, 2024

Is this issue still valid? I dont see any occurrences in the code

@Wondertan
Copy link
Member

Yes it is. This happens in a subtle way. The good thing is that soon the inverted index will be removed altogether with this issue via new protocol: #2971

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external Issues created by non node team members needs:triage pending:close
Projects
None yet
Development

No branches or pull requests

4 participants